Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] web_report_barcode_rotate: init #2886

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[ADD] web_report_barcode_rotate: init #2886

wants to merge 1 commit into from

Conversation

IT-Ideas
Copy link

@IT-Ideas IT-Ideas commented Jul 18, 2024 •
edited
Loading

This module adds the possibility to pass a rotate argument to the barcode generation route. The returned barcode image is then obviously rotated, which prevent having to use css in order to get the same result.

@IT-Ideas IT-Ideas force-pushed the 16.0-lst-web_report_barcode_rotate branch 2 times, most recently from 1572a65 to 88152f6 Compare July 18, 2024 12:46
AnizR
AnizR approved these changes Jul 18, 2024
View reviewed changes
Copy link

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Thanks for your contribution.

@IT-Ideas IT-Ideas force-pushed the 16.0-lst-web_report_barcode_rotate branch from 88152f6 to 4db0ee5 Compare July 18, 2024 12:56
rousseldenis
rousseldenis approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@IT-Ideas IT-Ideas force-pushed the 16.0-lst-web_report_barcode_rotate branch from 4db0ee5 to 972f71f Compare July 18, 2024 13:11
xavier-bouquiaux
xavier-bouquiaux approved these changes Jul 18, 2024
View reviewed changes
Copy link

@xavier-bouquiaux xavier-bouquiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work thanks a lot

@IT-Ideas IT-Ideas force-pushed the 16.0-lst-web_report_barcode_rotate branch 5 times, most recently from 7811a03 to ff49f29 Compare July 19, 2024 07:42
@IT-Ideas
Copy link
Author

Improved test suite in order to test all cases.

@IT-Ideas IT-Ideas force-pushed the 16.0-lst-web_report_barcode_rotate branch from ff49f29 to ad7e79a Compare July 19, 2024 07:46
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

FrancoMaxime
FrancoMaxime reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Laurent,

Thanks for your PR.
I think we should standardise the copyright section on the files.

Sorry

web_report_barcode_rotate/controllers/report.py Outdated Show resolved Hide resolved
web_report_barcode_rotate/tests/test_report_barcode_controller.py Outdated Show resolved Hide resolved
@IT-Ideas IT-Ideas force-pushed the 16.0-lst-web_report_barcode_rotate branch from ad7e79a to 0dc90cc Compare October 1, 2024 16:35
@IT-Ideas
Copy link
Author

IT-Ideas commented Oct 1, 2024

Hello Laurent,

Thanks for your PR. I think we should standardise the copyright section on the files.

Sorry

Good catch 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoMaxime FrancoMaxime FrancoMaxime left review comments

@xavier-bouquiaux xavier-bouquiaux xavier-bouquiaux approved these changes

@AnizR AnizR AnizR approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@IT-Ideas @OCA-git-bot @rousseldenis @FrancoMaxime @AnizR @xavier-bouquiaux