[17.0][MIG] web_save_discard_button

[joepsanders]

No description provided.

[legalsylvain]

/ocabot migration web_save_discard_button

[joepsanders]

@legalsylvain this module was migrated, codecov checks fail on existing code. (How) should I fix this?

[legalsylvain]

codecov checks fail on existing code.

No. V17 branch has a coverage of 95% (https://github.com/OCA/web/tree/17.0)
your patch has a coverage of 77% (https://app.codecov.io/gh/OCA/web/pull/2872?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=OCA)

If a PR propose code less covered, Codecov CI is red.

Once said, it's just 2 lines. If you think it's relevant to write a test on that topic, please do it. IMO, it's OK like this.

kind regards.

[joepsanders]

IMO, it's OK like this.

I agree, so how does this proceed?

[sanderlienaerts]

LGTM

[legalsylvain]

Hi @joepsanders : could you take a look if #2899 (review) is still present, and try to fix it if not ?

web_responsive should be installed.

thanks !

[sanderlienaerts]

This deprecated line may be removed. There are also some redundant lines due to being a default value already (https://www.odoo.com/documentation/17.0/developer/reference/backend/module.html).

[joepsanders]

Thanks, fixed the manifest. Please check :)

[sanderlienaerts]

Hi @joepsanders : could you take a look if #2899 (review) is still present, and try to fix it if not ?

web_responsive should be installed.

thanks !

Tested in 17.0 with web_save_discard_button and web_responsive installed, the bug presented there is not present.

[sanderlienaerts]

LGTM

[sanderlienaerts]

@legalsylvain can we push this forward?

[legalsylvain]

two review are required for merging !
feel free to review some PRs, to ask people to review your PR.

thanks !