Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] web_widget_text_count #2858

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[ADD] web_widget_text_count #2858

merged 1 commit into from
Oct 21, 2024

Conversation

leemannd
Copy link

@leemannd leemannd commented Jun 18, 2024 •
edited
Loading

Solving pre-commit issue of #1357 which is ready to be merged.

NB: the author of the previous PR is no longer active on the OCA

@leemannd leemannd mentioned this pull request Jun 18, 2024
Closed
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

simahawk commented Oct 8, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-2858-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 8, 2024
@OCA-git-bot
Merge PR #2858 into 12.0
e336a75 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-2858-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk simahawk changed the title [ADD] web_text_count_field [ADD] web_widget_text_count Oct 8, 2024
@simahawk
Copy link
Contributor

simahawk commented Oct 8, 2024

@leemannd I've blocked the merge: can you please squash the commits and amend the msg w/ the right module name?

@bosd
Copy link
Contributor

bosd commented Oct 10, 2024

Would love to get this one onv 14.

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-2858-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b60d907 into OCA:12.0 Oct 21, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a896df0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@bosd bosd bosd approved these changes

@StephaneMangin StephaneMangin StephaneMangin approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@leemannd @OCA-git-bot @simahawk @bosd @StephaneMangin @cyrilmanuel @asaunier