[16.0][MIG] web_m2x_options_manager : Migrated to 16.0. #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons from interface
- Fix postprocess inherit (removed from v15), and use _postprocess_tag_field for create/edit options: In v14 it worked with inheriting the "postprocess" method because in each recursive call it passed a section of the view, in the way that it went through all the child nodes of the root node, and passed through the fields, and now in v15 the method "_postprocess_view "it just does the while, and we never go through the nodes. - Fix pylint errors: xml-deprecated-tree-attributte, attribute-string-redundant, translation-positional-used
Ammar-OSI
changed the title
Ammar-OSI
force-pushed
the
16.0-MIG-option_manager
branch
2 times, most recently
from
6642aea
to
b4ead22
Compare
|
Thanks for the migration. I might be missing something but the module does not seem to work with a quick functional test in runboat - created a record to remove options from the customer field in sales order, and it does not seem to affect the behavior.
|
|
@Ammar-OSI this PR should depend on my PR: #2446 so that it can work |
anothingguy
suggested changes
Mar 14, 2023
| @@ -17,7 +17,7 @@ | |||
| "demo": [ | |||
| "demo/res_partner_demo_view.xml", | |||
| ], | |||
| "depends": ["base", "web_m2x_options"], | |||
| "depends": ["base"], | |||
There was a problem hiding this comment.
@Ammar-OSI: web_m2x_options_manager should depend on web_m2x_options
| @@ -367,7 +367,7 @@ <h1 class="title">Web M2X Options Manager</h1> | |||
| !! This file is generated by oca-gen-addon-readme !! | |||
| !! changes will be overwritten. !! | |||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! --> | |||
| <p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/web/tree/15.0/web_m2x_options_manager"><img alt="OCA/web" src="https://img.shields.io/badge/github-OCA%2Fweb-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_m2x_options_manager"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/162/15.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p> | |||
| <p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/web/tree/14.0/web_m2x_options_manager"><img alt="OCA/web" src="https://img.shields.io/badge/github-OCA%2Fweb-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/162/14.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p> | |||
There was a problem hiding this comment.
why we have 14.0 here ? I think it should be 16.0
patrickrwilson
force-pushed
the
16.0-MIG-option_manager
branch
from
b4ead22
to
a7ad010
Compare
|
@Ammar-OSI can you work on comments and fix pre-commit? |
|
@Ammar-OSI this module does also not cover the options "no_create_edit: True" and "no_create": True. When these options are set, the force add command will still not work! |
|
Hello @Ammar-OSI, thank you for your PR. I have created another PR to take over this PR: Your feedback/review is welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.