-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] web_ir_actions_act_view_reload: Migration to 15.0 #2240
[15.0][MIG] web_ir_actions_act_view_reload: Migration to 15.0 #2240
Conversation
Includes some manual fixes to silent ESLint warnings.
Unresolved reference self and module odoo.api has no attribute multi
* @returns {Promise} Resolved promise | ||
*/ | ||
_executeReloadAction: function () { | ||
var controller = this.getCurrentController(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does #2241 apply here as well?
This PR #2192 implies that the module breaks in some cases if the action is not defined as a model. Do you want to review it, and check if this is still true in Odoo 15? |
/ocabot migration web_ir_actions_act_view_reload |
@StefanRijnhart I was trying to setup # web_ir_actions_act_view_reload
cd oca/web
gh pr checkout 2240
../..
# hr_timesheet_task_stage
cd oca/timesheet
gh pr checkout 500
../..
# project_timesheet_time_control
cd oca/project
gh pr checkout 939
../.. For some reason the action |
@janikvonrotz That would be useful feedback to the author of this PR, @manuelcalerosolis |
@manuelcalerosolis The client throws this error:
|
Wow, it looks like the entry point @manuelcalerosolis did this code work for you locally on Odoo 15? |
@StefanRijnhart I also get the error when starting a timesheet within HelpDesk with the "Start Work" button. I really don't know what change I have to incorporate in the javascript module so that it works correctly in 15.0 |
Then maybe you should leave the migration of this module to someone else. |
Sure. Maybe that person is you. |
@StefanRijnhart Is there really no alternative in v15? Something like: |
Superseded by #2272 |
This is the migration of ir_actions_act_view_reload to 15.0