[MIG] web_widget_json_graph: Migration to 15.0 #2222

frahikLV · 2022-05-19T21:05:22Z

No description provided.

…CA#1733) This module allows to load a line graph per ordered pair from an One2many or Many2many field. Co-Authored-By: Francisco Luna <[email protected]> Co-Authored-By: José Robles <[email protected]> Co-Authored-By: Luis González <[email protected]> Co-Authored-By: Nhomar Hernández <[email protected]> Co-authored-by: Francisco Luna <[email protected]> Co-authored-by: José Robles <[email protected]> Co-authored-by: Nhomar Hernández <[email protected]>

luisg123v · 2022-05-19T22:27:28Z

@frahikLV could you open a new PR from vauxoo-dev and announce it on #2053, please?

luisg123v · 2022-05-19T22:40:22Z

web_widget_json_graph/__manifest__.py

@@ -0,0 +1,25 @@
+{
+    "name": "Web Widget JSON Graph",
+    "version": "15.0.1.0.1",


Suggested change

"version": "15.0.1.0.1",

"version": "15.0.1.0.0",

luisg123v · 2022-05-19T22:41:14Z

web_widget_json_graph/__manifest__.py

+    "license": "LGPL-3",
+    "category": "Hidden/Dependency",
+    "website": "https://github.com/OCA/web",
+    "maintainers": ["frahikLV"],


Don't remove maintainers. Add yourself to existing ones if that's what you want.

Maybe you can add them like:

"maintainers": [ "luisg123v", "frahikLV", ],

luisg123v · 2022-05-19T22:43:56Z

web_widget_json_graph/static/src/js/web_widget_json_graph.js

@@ -0,0 +1,27 @@
+/* eslint no-undef: 0*/


What error are you avoiding here?

Could it be specific to the problematic line?

Done, moved to line 18

luisg123v · 2022-05-19T22:55:36Z

Hi @hugho-ad, @CarmenMiranda

Could you review, please?

@frahikLV let's keep this PR, next time we can use vauxoo-dev

CC @moylop260 @desdelinux

CarmenMiranda · 2022-05-19T23:06:14Z

web_widget_json_graph/__manifest__.py

+    "license": "LGPL-3",
+    "category": "Hidden/Dependency",
+    "website": "https://github.com/OCA/web",
+    "maintainers": ["frahikLV"],


Maybe you can add them like:

"maintainers": [ "luisg123v", "frahikLV", ],

CarmenMiranda · 2022-05-19T23:09:13Z

web_widget_json_graph/__manifest__.py

+    "data": [],
+    "assets": {
+        "web.assets_backend": [
+            "web_widget_json_graph/static/src/js/web_widget_json_graph.js"


Can you add the comma at the end?? So if more assets are added later on just a line is added and they don't have to edit your line to add the comma and add another line, also it helps keep a better track of commits 😄

Same in the "web.assets_qweb"

CarmenMiranda · 2022-05-19T23:13:03Z

web_widget_json_graph/static/src/js/web_widget_json_graph.js

-            "/web/static/src/js/libs/nvd3.js",
-        ],
-        _render: function () {
+        jsLibs: ["/web/static/lib/Chart/Chart.js"],


Can you separate the list??

jsLibs: [ "/web/static/lib/Chart/Chart.js", ],

So if more libs are added later on just a line is added and they don't have to edit your line to add the comma, break the line, and add another line, also it helps keep a better track of commits

This is black I think. If so, it can't be avoided

Drop, it's JS code

Note: This change cannot be applied because prettier returns it to the current format.

Ohh, ok, It's ok 😄

frahikLV · 2022-05-20T16:20:33Z

@luisg123v Suggestions have been addressed, could you review again?

cc: @CarmenMiranda

CarmenMiranda · 2022-05-20T17:20:18Z

web_widget_json_graph/static/src/js/web_widget_json_graph.js

-                });
-            }
-            /* Jsl:end*/
+            var cx = document.createElement("canvas");


Just a question, here you are creating another element canvas but you already have it in the template JSONGraph why don't you use it like these examples??

web_kanban_gauge

website_links

Good suggestion

frahikLV · 2022-05-20T21:51:39Z

@luisg123v Done, I applied all the suggestions, can you review it?

cc: @CarmenMiranda

CarmenMiranda

Technically LGTM 👍🏼

luisg123v

LGTM 👍

@moylop260 @hugho-ad, what do you think?

luisg123v · 2022-05-21T02:28:31Z

/ocabot merge nobump

OCA-git-bot · 2022-05-21T02:28:51Z

Sorry @luisg123v you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

luisg123v · 2022-05-21T02:31:14Z

Hi @moylop260,

Since this module is not merged into the base branch, I'm not able to merge because I'm not registered as a maintainer on that branch.

Could you run the command by me, please?

Regards,

moylop260 · 2022-05-21T05:49:05Z

/ocabot merge nobump

OCA-git-bot · 2022-05-21T05:49:14Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2222-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2022-05-21T05:53:58Z

Congratulations, your PR was merged at 0a86047. Thanks a lot for contributing to OCA. ❤️

luisg123v and others added 3 commits May 19, 2022 15:45

[UPD] README.rst

dd30b9b

[IMP] web_widget_json_graph: black, isort, prettier

b9c1cae

luisg123v suggested changes May 19, 2022

View reviewed changes

CarmenMiranda suggested changes May 19, 2022

View reviewed changes

frahikLV force-pushed the 15.0-mig-web_widget_json_graph branch 2 times, most recently from a07cd32 to 881cc54 Compare May 20, 2022 16:17

CarmenMiranda reviewed May 20, 2022

View reviewed changes

frahikLV force-pushed the 15.0-mig-web_widget_json_graph branch from 881cc54 to 73c2487 Compare May 20, 2022 21:44

frahikLV mentioned this pull request May 20, 2022

Migration to version 15.0 #2053

Open

47 tasks

frahikLV force-pushed the 15.0-mig-web_widget_json_graph branch from 73c2487 to c5db5ee Compare May 20, 2022 21:48

[MIG] web_widget_json_graph: Migration to 15.0

893247b

frahikLV force-pushed the 15.0-mig-web_widget_json_graph branch from c5db5ee to 893247b Compare May 20, 2022 21:49

CarmenMiranda approved these changes May 20, 2022

View reviewed changes

luisg123v approved these changes May 21, 2022

View reviewed changes

OCA-git-bot added the approved label May 21, 2022

hugho-ad approved these changes May 21, 2022

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 21, 2022

OCA-git-bot merged commit b32101b into OCA:15.0 May 21, 2022

OCA-git-bot removed the bot is merging ⏳ label May 21, 2022

OCA-git-bot added the merged 🎉 label May 21, 2022

frahikLV deleted the 15.0-mig-web_widget_json_graph branch May 21, 2022 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] web_widget_json_graph: Migration to 15.0 #2222

[MIG] web_widget_json_graph: Migration to 15.0 #2222

frahikLV commented May 19, 2022

luisg123v commented May 19, 2022

luisg123v May 19, 2022

frahikLV May 20, 2022

luisg123v May 19, 2022

CarmenMiranda May 19, 2022

frahikLV May 20, 2022

luisg123v May 19, 2022

frahikLV May 20, 2022

luisg123v commented May 19, 2022

CarmenMiranda May 19, 2022

CarmenMiranda May 19, 2022

frahikLV May 20, 2022

CarmenMiranda May 19, 2022

luisg123v May 19, 2022

luisg123v May 19, 2022

frahikLV May 20, 2022

frahikLV May 20, 2022

CarmenMiranda May 20, 2022

frahikLV commented May 20, 2022

CarmenMiranda May 20, 2022 •

edited

Loading

frahikLV May 20, 2022

frahikLV commented May 20, 2022

CarmenMiranda left a comment

luisg123v left a comment

luisg123v commented May 21, 2022

OCA-git-bot commented May 21, 2022

luisg123v commented May 21, 2022 •

edited

Loading

moylop260 commented May 21, 2022

OCA-git-bot commented May 21, 2022

OCA-git-bot commented May 21, 2022

[MIG] web_widget_json_graph: Migration to 15.0 #2222

[MIG] web_widget_json_graph: Migration to 15.0 #2222

Conversation

frahikLV commented May 19, 2022

luisg123v commented May 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luisg123v commented May 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frahikLV commented May 20, 2022

CarmenMiranda May 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frahikLV commented May 20, 2022

CarmenMiranda left a comment

Choose a reason for hiding this comment

luisg123v left a comment

Choose a reason for hiding this comment

luisg123v commented May 21, 2022

OCA-git-bot commented May 21, 2022

luisg123v commented May 21, 2022 • edited Loading

moylop260 commented May 21, 2022

OCA-git-bot commented May 21, 2022

OCA-git-bot commented May 21, 2022

CarmenMiranda May 20, 2022 •

edited

Loading

luisg123v commented May 21, 2022 •

edited

Loading