Skip to content

Commit

Permalink
[FIX] web_widget_numeric_step: Remove focus to avoid annoying flicker…
Browse files Browse the repository at this point in the history
…ing effect

The focus introduced on the 16.0 migration is causing a flickering effect
that is a bit annoying and does not make complete sense, because if you
click more than once the cursor is positioned at the end of the text,
which makes it difficult to edit the input.

The counterpart of these changes is that to edit the input using the
keyboard we will have to click on the field. Although this is how the
module has been operating since its inception.
  • Loading branch information
CarlosRoca13 committed Aug 8, 2024
1 parent 12ba87c commit 087ea08
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions web_widget_numeric_step/static/src/numeric_step.esm.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@ import {registry} from "@web/core/registry";
import {standardFieldProps} from "@web/views/fields/standard_field_props";
import {_lt} from "@web/core/l10n/translation";
import {FloatField} from "@web/views/fields/float/float_field";
import {hasTouch} from "@web/core/browser/feature_detection";

export class NumericStep extends FloatField {
setup() {
super.setup();
}
_onStepClick(ev) {
const $el = $(ev.target).parent().parent().find("input");
if (!hasTouch()) {
$el.focus();
}
const mode = $(ev.target).data("mode");
this._doStep(mode);
}
Expand Down

0 comments on commit 087ea08

Please sign in to comment.