[18.0][MIG] stock_picking_line_sequence #1864

StefanRijnhart · 2025-02-03T15:58:41Z

Standard migration, based on unmerged #1552.

Code moved to one file per model as suggested in [17.0] [MIG] stock_picking_line_sequence: Migration to V17 #1552
Includes an improved version of [16.0][FIX] stock_picking_line_sequence model_create_multi #1861
Column sequence2 is renamed to visible_sequence as in the other *_line_sequence models, incl. data migration

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Currently translated at 100.0% (7 of 7 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/pt_BR/

Currently translated at 100.0% (7 of 7 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/sl/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/

Currently translated at 28.5% (2 of 7 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_line_sequence/it/

only update the sequence number when the line number is an integer.

Currently translated at 100.0% (7 of 7 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_line_sequence/es/

Currently translated at 100.0% (7 of 7 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_line_sequence/it/

StefanRijnhart · 2025-02-03T16:20:24Z

/ocabot migration stock_picking_line_sequence

youring

Functional.

stock_picking_line_sequence/models/stock_move.py

…sequence

jbaudoux

Thanks, LG. Minor remarks

jbaudoux · 2025-02-11T10:47:29Z

stock_picking_line_sequence/models/stock_move.py

+    _inherit = "stock.move"
+
+    # re-defines the field to change the default
+    sequence = fields.Integer("HiddenSequence", default=9999)


Suggested change

sequence = fields.Integer("HiddenSequence", default=9999)

sequence = fields.Integer("Hidden sequence", default=9999)

Thanks. I removed the string label entirely analogous to sale_order_line_sequence.

jbaudoux · 2025-02-11T10:48:12Z

stock_picking_line_sequence/models/stock_move.py

+
+    @api.model_create_multi
+    def create(self, vals_list):
+        """(re)initialize the sequences of the moves within a picking"""


Do not change create docstring

Suggested change

"""(re)initialize the sequences of the moves within a picking"""

# (re)initialize the sequences of the moves within a picking"""

Isn't a docstring the best way to document what a method (or an override) does?

A method yes. An override no as it's overriding the docstring of what create does

I must admit that it is out of intuition that I have been doing this, but I have been doing this for over a decade. Do you have a pointer to an Odoo or OCA guideline about this?

No I don't. But you can check if my saying is right by opening a shell and running help(env["stock.move"].create)

@rousseldenis Do you agree with the suggestion not to mask the original docstring? What would give the best usability in visual IDEs (that I don't use)?

@StefanRijnhart yes, your suggestion is the good one.

@rousseldenis you mean the one with docstring or comment?

By the way, it's not an override (where docstring would be right) but an extend (where it's debatable)

@rousseldenis Indeed, I was talking about jbaudoux' suggestion to replace the docstring by a comment.

youring · 2025-02-14T02:32:52Z

stock_picking_line_sequence/report/report_deliveryslip.xml

+        </xpath>
+        <xpath expr="//table[2]/thead/tr/th[1]" position="before">
+            <th>
+                <strong>Seq.</strong>


Suggested change

Seq.

Line Number

youring · 2025-02-14T04:02:41Z

stock_picking_line_sequence/report/report_deliveryslip.xml

+    <template id="report_delivery_document" inherit_id="stock.report_delivery_document">
+        <xpath expr="//table[1]/thead/tr/th[1]" position="before">
+            <th>
+                <strong>Seq.</strong>


Suggested change

Seq.

Line Number

youring · 2025-02-14T05:49:32Z

stock_picking_line_sequence/models/stock_move.py

+
+    # displays sequence on the stock moves
+    visible_sequence = fields.Integer(
+        "Sequence",


Suggested change

"Sequence",

"Line Number",

…equence modules

AurelijaNorvaisaite · 2025-02-17T08:09:30Z

stock_picking_line_sequence/models/stock_picking.py

+            current_sequence = 1
+            for line in rec.move_ids_without_package:
+                # Check if the record ID is an integer (real ID)
+                # or a string (virtual ID)


virtual ID should be of NewId type, not string

Comment updated.

StefanRijnhart force-pushed the 18.0-mig-stock_picking_line_sequence branch from 47c4d60 to 1a3f7c4 Compare February 3, 2025 16:02

serpentcs-dev1 and others added 28 commits February 3, 2025 17:05

[MIG] stock_picking_line_sequence v9

cc03156

[MIG] stock_picking_line_sequence v10

22c6e3e

[IMP] docstring

fa3900d

OCA Transbot updated translations from Transifex

e559c6a

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[UPD] Update stock_picking_line_sequence.pot

933d374

[10.0][FIX] stock_picking_line_sequence module

5496a1d

[MIG] stock_picking_line_sequence migrated to version 12.0

eea72d6

[ADD] icon.png

425a9dd

[FIX]keep original sequence when creating backorders

53eed6d

[IMP] Add sequence to delivery slip report

051f5a6

[UPD] Update stock_picking_line_sequence.pot

0ab5feb

[FIX] stock picking line unuseful and very slow update

20535fb

[IMP] stock_picking_line_sequence: black, isort, prettier

0cf56dd

[MIG] stock_picking_line_sequence: Migration to 14.0

9d4a634

[UPD] contributors: Eficent -> ForgeFlow

81d4bfc

[IMP] stock_picking_line_sequence: black, isort, prettier

4df1567

[MIG] stock_picking_line_sequence: Migration to 15.0

2cd74a7

[MIG] stock_picking_line_sequence: Migration to 16.0

5fa704a

[FIX] stock_picking_line_sequence: sequence number

5cd5a83

only update the sequence number when the line number is an integer.

[17.0-mig-stock] [IMP] stock_picking_line_sequence: pre-commit stuff

21825c1

[MIG] stock_picking_line_sequence: Migration to 17.0

3558f18

[IMP] stock_picking_line_sequence: pre-commit auto fixes

4f5265c

StefanRijnhart force-pushed the 18.0-mig-stock_picking_line_sequence branch from 1a3f7c4 to 59fe8d3 Compare February 3, 2025 16:09

StefanRijnhart marked this pull request as ready for review February 3, 2025 16:20

OCA-git-bot added this to the 18.0 milestone Feb 3, 2025

OCA-git-bot mentioned this pull request Feb 3, 2025

Migration to version 18.0 #1737

Open

41 tasks

StefanRijnhart force-pushed the 18.0-mig-stock_picking_line_sequence branch from 59fe8d3 to 61b2bd4 Compare February 3, 2025 16:21

StefanRijnhart and others added 3 commits February 3, 2025 17:32

[MIG] stock_picking_line_sequence: Migration to 18.0

3cf30b0

[REF] stock_picking_line_sequence: one file per model

eb1307f

[FIX] stock_picking_line_sequence: create with api.model_create_multi

f17537d

StefanRijnhart force-pushed the 18.0-mig-stock_picking_line_sequence branch from 61b2bd4 to f17537d Compare February 3, 2025 16:32

This was referenced Feb 3, 2025

[16.0][FIX] stock_picking_line_sequence model_create_multi #1861

Open

[17.0] [MIG] stock_picking_line_sequence: Migration to V17 #1552

Open

youring approved these changes Feb 5, 2025

View reviewed changes

stock_picking_line_sequence/models/stock_move.py Outdated Show resolved Hide resolved

[REF] stock_picking_line_sequence: rename field sequence2 to visible_…

93a4fdf

…sequence

jbaudoux reviewed Feb 11, 2025

View reviewed changes

youring reviewed Feb 14, 2025

View reviewed changes

youring approved these changes Feb 14, 2025

View reviewed changes

youring suggested changes Feb 14, 2025

View reviewed changes

[REF] stock_picking_line_sequence: align field labels to other line_s…

a0a74cc

…equence modules

AurelijaNorvaisaite reviewed Feb 17, 2025

View reviewed changes

[IMP] stock_picking_line_sequence: update inline comment

a1c2aef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] stock_picking_line_sequence #1864

[18.0][MIG] stock_picking_line_sequence #1864

StefanRijnhart commented Feb 3, 2025 •

edited

Loading

StefanRijnhart commented Feb 3, 2025

youring left a comment

jbaudoux left a comment

jbaudoux Feb 11, 2025

StefanRijnhart Feb 14, 2025

jbaudoux Feb 11, 2025

StefanRijnhart Feb 11, 2025

jbaudoux Feb 11, 2025

StefanRijnhart Feb 11, 2025

jbaudoux Feb 11, 2025

StefanRijnhart Feb 11, 2025 •

edited

Loading

rousseldenis Feb 11, 2025

jbaudoux Feb 11, 2025

StefanRijnhart Feb 12, 2025

StefanRijnhart Feb 14, 2025

youring Feb 14, 2025

StefanRijnhart Feb 14, 2025

youring Feb 14, 2025

StefanRijnhart Feb 14, 2025

youring Feb 14, 2025

StefanRijnhart Feb 14, 2025

AurelijaNorvaisaite Feb 17, 2025

StefanRijnhart Feb 17, 2025

	sequence = fields.Integer("HiddenSequence", default=9999)
	sequence = fields.Integer("Hidden sequence", default=9999)

	"""(re)initialize the sequences of the moves within a picking"""
	# (re)initialize the sequences of the moves within a picking"""

	<strong>Seq.</strong>
	<strong>Line Number</strong>

	<strong>Seq.</strong>
	<strong>Line Number</strong>

[18.0][MIG] stock_picking_line_sequence #1864

Are you sure you want to change the base?

[18.0][MIG] stock_picking_line_sequence #1864

Conversation

StefanRijnhart commented Feb 3, 2025 • edited Loading

StefanRijnhart commented Feb 3, 2025

youring left a comment

Choose a reason for hiding this comment

jbaudoux left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanRijnhart Feb 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanRijnhart commented Feb 3, 2025 •

edited

Loading

StefanRijnhart Feb 11, 2025 •

edited

Loading