Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] stock_restrict_lot_update #1442

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[ADD] stock_restrict_lot_update #1442

merged 1 commit into from
Dec 7, 2023

Conversation

aleuffre
Copy link
Contributor

@aleuffre aleuffre commented Nov 29, 2023 •
edited
Loading

This module builds on stock_restrict_lot and exposes the field
restrict_lot_id allowing the user to update or even remove
the lot restriction if the product does not fall within a domain.

The domain can be updated in the settings of each individual company.

TODO:

  • Tests
  • documentation

@aleuffre aleuffre force-pushed the 14.0-stock_restrict_lot_domain branch 5 times, most recently from 8b9eacc to ea6fb20 Compare December 1, 2023 15:17
ilyasProgrammer
ilyasProgrammer approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ilyasProgrammer ilyasProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
picky: missing copyright in files

@aleuffre aleuffre force-pushed the 14.0-stock_restrict_lot_domain branch 2 times, most recently from b2e71c0 to 04bd567 Compare December 5, 2023 16:07
@aleuffre
Copy link
Contributor Author

aleuffre commented Dec 5, 2023

LGTM
picky: missing copyright in files

Added copyright for the sake of having the PR merged, though I'm not sure it's strictly necessary.

geomer198
geomer198 reviewed Dec 5, 2023
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is optional but code will look better.

stock_restrict_lot_update/tests/test_restrict_lot_update.py Show resolved Hide resolved
stock_restrict_lot_update/models/stock_move.py Show resolved Hide resolved
@aleuffre aleuffre force-pushed the 14.0-stock_restrict_lot_domain branch from 04bd567 to 7525e1c Compare December 6, 2023 08:38
geomer198
geomer198 approved these changes Dec 6, 2023
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@aleuffre aleuffre force-pushed the 14.0-stock_restrict_lot_domain branch 3 times, most recently from 93fdf40 to 43bdca0 Compare December 6, 2023 13:17
francesco-ooops
francesco-ooops approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok, we got USAGE file too

@pedrobaeza good for you?

@pedrobaeza pedrobaeza added this to the 14.0 milestone Dec 7, 2023
@pedrobaeza
Copy link
Member

I think in this case a CONTEXT file explaining why do you want to do this update is interesting.

@aleuffre aleuffre force-pushed the 14.0-stock_restrict_lot_domain branch from 43bdca0 to 48f2883 Compare December 7, 2023 11:28
@aleuffre
Copy link
Contributor Author

aleuffre commented Dec 7, 2023

I think in this case a CONTEXT file explaining why do you want to do this update is interesting.

I've added a CONTEXT file.

@pedrobaeza
Copy link
Member

Thanks:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1442-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dd438e6 into OCA:14.0 Dec 7, 2023
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a49159e. Thanks a lot for contributing to OCA. ❤️

@aleuffre aleuffre deleted the 14.0-stock_restrict_lot_domain branch December 7, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyasProgrammer ilyasProgrammer ilyasProgrammer approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@geomer198 geomer198 geomer198 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aleuffre @OCA-git-bot @pedrobaeza @ilyasProgrammer @francesco-ooops @geomer198