[16.0][FW] procurement_auto_create_group: partial ports of #1821 #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not override rule1 during setup, renamed the 2 rules.
Regroup the creation of the procurement group in a method.
When the pull flow is coming from an SO, a procurement group is already preset. When the option to auto create a procurement group, replace that procurement group by a new one.
sebalix
force-pushed
the
16-port-from-14-procurement_auto_create_group
branch
from
fa18ad8
to
9993236
Compare
sebalix
commented
Sep 18, 2024
| new_move_vals["group_id"] = group.id | ||
| return new_move_vals | ||
|
|
||
| def _prepare_auto_procurement_group_data(self): | ||
| def _prepare_auto_procurement_group_data(self, product): |
There was a problem hiding this comment.
Any override of this method will break once merged.
In OCA, it is only overridden in procurement_auto_create_group_carrier and procurement_auto_create_group_by_product which are not yet available on 16.0.
henrybackman
approved these changes
Sep 25, 2024
jbaudoux
approved these changes
Sep 30, 2024
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 839557b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port commits related to
procurement_auto_create_groupfrom the following PR from 14.0 to 16.0:Required by: