Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] stock_picking_volume: pre_init_hook, replace column type from numeric to double precision #2151

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[16.0][FIX] stock_picking_volume: pre_init_hook, replace column type from numeric to double precision #2151

merged 1 commit into from
Oct 8, 2024

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Sep 2, 2024 •
edited
Loading

As no digits parameters are provided on <stock.move>.volume and <stock.picking>.volume fields, the double precision type is used instead of numeric.

This avoids time consuming SQL requests ALTER TABLE... at module install.

@sebalix
stock_picking_volume: pre_init_hook, replace column type from 'numeri…
a8c6200 
…c' to 'double precision'

As no digits parameters are provided on `<stock.move>.volume' and
'<stock.picking>.volume' fields, the 'double precision' type is used
instead of 'numeric'.

This avoids time consuming SQL requests 'ALTER TABLE...' at module
install.
@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sebalix sebalix marked this pull request as ready for review September 2, 2024 08:35
@sebalix sebalix requested a review from lmignon September 2, 2024 08:35
jbaudoux
jbaudoux approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2151-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 18e886f into OCA:16.0 Oct 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a597c54. Thanks a lot for contributing to OCA. ❤️

@sebalix sebalix deleted the 16-stock_picking_volume-fix-pre_init_hook branch October 24, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebalix @OCA-git-bot @rousseldenis @lmignon @jbaudoux