[14.0][FIX] stock_move_location: take values from the current transient model #2106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
The previous implementation of _get_move_values(self, picking, lines) relied on data from the transient model "wiz.stock.move.location.line". This approach led to potential inconsistencies between stock_move_location_line_ids.destination_location_id and self.destination_location_id.
Previous Implementation
location_from_id = lines[0].origin_location_id.id
location_to_id = lines[0].destination_location_id.id
The issue arose when the _onchange_destination_location_id(self) method was not properly triggered:
If this onchange method wasn't called correctly, _get_move_values(self, picking, lines) would use potentially outdated values from lines.destination_location_id.id, leading to errors
Proposed Solution
To resolve this issue, we now use values directly from the current transient model "wiz.stock.move.location":
This change ensures consistency and eliminates the dependency on the proper execution of the onchange method