-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] stock_exception #2063
base: 17.0
Are you sure you want to change the base?
Conversation
/ocabot migration stock_exception |
de1e3cc
to
2eecda2
Compare
@rousseldenis @patrickrwilson Code updated and All checks green. Can you please take a look? |
2eecda2
to
8fe9539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -43,6 +43,12 @@ def action_confirm(self): | |||
return rec._popup_exceptions() | |||
return super().action_confirm() | |||
|
|||
def button_validate(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Urvisha-OSI Could you update DESCRIPTION and/or USAGE to reflect this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis I added a sentence to the Description file.
LGTM |
Adding some more info to the description for when exceptions are checked.
No description provided.