Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] stock_barcodes: Allow scan barcode camera #665

Closed
wants to merge 1 commit into from

Conversation

edescalona
Copy link

The option to scan barcodes with the camera has been added.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to clean the PR, removing unneeded changes in README, readme folder, extra spaces or empty lines.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 17, 2024
@edescalona edescalona changed the title [16.0][IMP] Allow scan barcode camera [16.0][IMP] stock_barcodes: Allow scan barcode camera Dec 17, 2024
@edescalona edescalona force-pushed the 16.0-imp-barcode-camera branch 3 times, most recently from accc4f4 to 6881f7b Compare December 17, 2024 17:43
[IMP] Add Tests

[IMP] Readme

[FIX] Readme and index

[IMP] Add Tests

[FIX] Suggested changes
@edescalona edescalona force-pushed the 16.0-imp-barcode-camera branch from 53f9ad8 to 88e7f6d Compare December 17, 2024 18:17
@edescalona
Copy link
Author

Hi @pedrobaeza , I've already made some changes, please let me know when you can, thanks

@pedrobaeza pedrobaeza dismissed their stale review December 17, 2024 18:39

Changes fulfilled

@pedrobaeza
Copy link
Member

OK, thanks, I remove my "Requested changes", but I'm not able to review further for now.

@edescalona
Copy link
Author

OK, thanks, I remove my "Requested changes", but I'm not able to review further for now.

@edescalona edescalona closed this Dec 17, 2024
@edescalona edescalona reopened this Dec 17, 2024
@edescalona
Copy link
Author

Ok @pedrobaeza , thank you very much for your collaboration.

@edescalona edescalona closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants