Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][UPD] mail_composer_cc_bcc: propose maintainer #1520

Merged
merged 1 commit into from
Dec 21, 2024
Merged

[16.0][UPD] mail_composer_cc_bcc: propose maintainer #1520

merged 1 commit into from
Dec 21, 2024
+6 −6

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Dec 16, 2024 •
edited
Loading

Context

  • @hailangvn was the original author and maintainer of the module mail_composer_cc_bcc
  • However, he is currently away from the office for personal reasons, and won't be back before a few months
  • Hai and myself are part of the same company: Trobz
  • So I propose myself as a maintainer of the module

@OCA-git-bot
Copy link
Contributor

Hi @hailangvn2023,
some modules you are maintaining are being modified, check this out!

@trisdoan trisdoan force-pushed the 16.0-add-mail_composer_cc_bcc-add-maintainer branch from 031774a to d48a662 Compare December 16, 2024 02:16
@trisdoan
Copy link
Contributor Author

cc: @nilshamerlinck, @hbrunn

@trisdoan trisdoan force-pushed the 16.0-add-mail_composer_cc_bcc-add-maintainer branch 3 times, most recently from 11f82f0 to 0751f6a Compare December 17, 2024 03:30
hbrunn
hbrunn requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this just one commit adding you as maintainer and leave the rest to the other PRs

@trisdoan trisdoan force-pushed the 16.0-add-mail_composer_cc_bcc-add-maintainer branch from 0751f6a to bf927b1 Compare December 20, 2024 01:56
@trisdoan trisdoan requested a review from hbrunn December 20, 2024 02:00
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Dec 21, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1520-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 50cb83f into OCA:16.0 Dec 21, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ddf6d2e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn approved these changes

@nilshamerlinck nilshamerlinck nilshamerlinck approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trisdoan @OCA-git-bot @hbrunn @nilshamerlinck