[16.0][MIG] mail_embed_image module #1499
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneMangin
force-pushed
the
cid_content_change_and_data_embeddings
branch
4 times, most recently
from
47b33e5 to
022e0d3
Compare
StephaneMangin
force-pushed
the
cid_content_change_and_data_embeddings
branch
from
022e0d3 to
6dc1479
Compare
StephaneMangin
changed the title
StephaneMangin
changed the title
hbrunn
requested changes
Dec 12, 2024
| ): | ||
| image_path = img.get("src") | ||
| try: | ||
| response = requests.get(image_path, timeout=10) |
There was a problem hiding this comment.
please add a test case where we have an image with a relative url, I believe this will fail here
| > | ||
| <span class="o_form_label">Email Preprocessing</span> | ||
| <div class="text-muted"> | ||
| Method used to embed images in HTML emails. CIDs attachment does not work with all email clients. Data SRC is more reliable. |
There was a problem hiding this comment.
that actually depends very much on the clients you target, with old outlooks it's the other way around. I'd propose not to make claim about what works better, and rather suggest to test with whatever are the expected mail clients
There was a problem hiding this comment.
Issue regarding Outlook has been tackled elsewhere. WIP
Need more testing regarding it before proposing.
StephaneMangin
force-pushed
the
cid_content_change_and_data_embeddings
branch
2 times, most recently
from
d77d383 to
476b0ef
Compare
- CIDs are not working in some email managers (gmail and office365) To allow this behavior we need to change the content type to multipart/related and reorganize the parts (see comments in code) - A new option to embed images is to include the base64 content inside the src. - Then to select these options, a selected field has been added to company
StephaneMangin
force-pushed
the
cid_content_change_and_data_embeddings
branch
from
476b0ef to
f81e4c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseed #1402