[16.0][FIX]mail_quoted_reply: unintentional tags #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophAbenthungCibex
force-pushed
the
16.0-mail_quoted_reply_unintenional_tags
branch
from
7704743
to
4514d7e
Compare
<...> text of subject and from are interpreted as tags and thus not shown in the composer. The unintentional tag may lead to browser problems because the browser sees it as an opening tag without a closing one.
ChristophAbenthungCibex
force-pushed
the
16.0-mail_quoted_reply_unintenional_tags
branch
from
4514d7e
to
5ddd721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<...> text of subject and from in the quoted reply block are interpreted as tags and thus not shown in the composer. The unintentional tag may lead to browser problems because the browser sees it as an opening tag without a closing one.
Steps to reproduce
Reply to any message. The composer will open and from field at the reply will only show the name and not the e-mail address. Inspecting with the developer tools of the browser shows that the e-mail address is interpreted as a tag. The same behavior can be observed for the subject for the reply (in the quoted reply block)