[16.0][IMP] base_tier_validation: support computed state field #970
+231
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LoisRForgeFlow, |
antonioburic
force-pushed
the
16.0-imp-base_tier_validation-computed_state_field
branch
2 times, most recently
from
6e019ed
to
56bbea8
Compare
Computed fields bypass `write`, so we need to override `_write` for that case. Also, the current value before the update needs to be fetched from the database because the new value is already set in the cache.
antonioburic
force-pushed
the
16.0-imp-base_tier_validation-computed_state_field
branch
from
56bbea8
to
e0d791d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computed fields bypass
write, so we need to override_writefor that case. Also, the current value before the update needs to be fetched from the database because the new value is already set in the cache.backport of #939