Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] base_tier_validation reminder option #960

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[14.0][FIX] base_tier_validation reminder option #960

merged 1 commit into from
Oct 31, 2024
+1 −1

Conversation

TDu
Copy link
Member

@TDu TDu commented Oct 28, 2024

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@LoisRForgeFlow
Copy link
Contributor

Hi @TDu any chance you can finish the fwport to v17 (#931) before merging fixes in 14?

@TDu
Copy link
Member Author

TDu commented Oct 31, 2024

Hello @LoisRForgeFlow, the reminder for it hangs in my mailbox but I have so many other things to tackle at the moment...maybe soon

LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LoisRForgeFlow
Copy link
Contributor

Hello @LoisRForgeFlow, the reminder for it hangs in my mailbox but I have so many other things to tackle at the moment...maybe soon

Hi, thanks for the info. You know, I'm just trying that versions are more or less aligned. Thanks for your efforts.

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-960-by-LoisRForgeFlow-bump-patch, awaiting test results.

@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Oct 31, 2024
Open
@OCA-git-bot OCA-git-bot merged commit cf55f19 into OCA:14.0 Oct 31, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3b3a6d. Thanks a lot for contributing to OCA. ❤️

@henrybackman henrybackman mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@henrybackman henrybackman henrybackman approved these changes

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 Pending to fw/back port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TDu @OCA-git-bot @LoisRForgeFlow @sebalix @henrybackman