[18.0][MIG] server_action_mass_edit: Migration to 18.0

[trisdoan]

No description provided.

[pedrobaeza]

/ocabot migration server_action_mass_edit

[florenciafrigieri2]

@trisdoan Hi! I tested the module but it didn't worked.
I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error:
File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange
dynamic_fields["selection__" + line.field_id.name] = fields.Selection(
File "/opt/odoo/odoo/fields.py", line 2772, in init
self._selection = dict(selection) if isinstance(selection, list) else None
ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action

[trisdoan]

@trisdoan Hi! I tested the module but it didn't worked. I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error: File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange dynamic_fields["selection__" + line.field_id.name] = fields.Selection( File "/opt/odoo/odoo/fields.py", line 2772, in init self._selection = dict(selection) if isinstance(selection, list) else None ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action

Hi @florenciafrigieri2, thank you for the review

I just added a fix, could you please try again?

[TDu]

I don't see the error mentioned by @florenciafrigieri2 anymore, but I am not familiar with this module !
Code review looks good.

[henrybackman]

Couple of minor comments

[henrybackman]

Would setUpClass work for the common test setup to avoid running the setup separately for each test case?

[henrybackman]

Suggested change

	def test_wiz_fields_view_get(self):
	"""Test whether fields_view_get method returns arch.
	def test_wiz_get_view(self):
	"""Test whether get_view method returns arch.

[henrybackman]

Suggested change

	"""Without this call, dynamic fields build by fields_view_get()
	"""Without this call, dynamic fields build by get_view()

[florenciafrigieri2]

Functional test! Now is working ok!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[stefsava]

It seems like there is a regression.
I can't bulk insert product attributes, while I could do it in 17.0.

Before it asked me to add a line,
now it doesn't ask and there are multiple columns.

With 17.0

With 18.0 and this PR

[legalsylvain]

See @stefsava comment.

[trisdoan]

Hello @stefsava, I checked and it looks to me that the issue is not because of the module

1. I tried with different o2m fields in another model
   

2. For product attribute, after https://github.com/odoo/odoo/pull/160270, there is a list view created and it has attribute create='false'. I changed to create='true' (for testing only), here's result:
   

[stefsava]

Hello @trisdoan

your suggestion doesn't solve my use case.

If I change create='true' I can see "Add a row", but the choice doesn't lead to anything useful.

Instead I found a workaround that brings the behavior back to that of 17.0 that I think can help you understand the problem detected.

I discovered that 17.0 only has the view "product.template.attribute.line.form" while
18.0 has added "product.template.attribute.line.view.list", and for some reason that I don't understand the list view is chosen instead of the form view.

My workaround was simply to deactive the list view, although I fear it may introduce regressions elsewhere.