Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] impersonate_login #714

Open
wants to merge 11 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] impersonate_login #714

wants to merge 11 commits into from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 17, 2024

Standard migration.
Includes #686

@astirpe astirpe marked this pull request as ready for review October 17, 2024 07:02
bealdav
bealdav approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested feature, works as expected

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebastienbeau
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-714-by-sebastienbeau-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 19, 2024
@OCA-git-bot
Merge PR #714 into 18.0
ae49e77 
Signed-off-by sebastienbeau
@OCA-git-bot
Copy link
Contributor

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-714-by-sebastienbeau-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@akavanom
Copy link

akavanom commented Jan 6, 2025

@sebastienbeau Can you check the issue when merging here, pre-commit test seems to fail, but it seems successful on the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bealdav bealdav bealdav approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@astirpe @OCA-git-bot @sebastienbeau @akavanom @rvalyi @bealdav @Kev-Roche @mymage