Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to skip the logout confirmation in the auth provider #708

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

Add support to skip the logout confirmation in the auth provider #708

wants to merge 1 commit into from

Conversation

wluyima
Copy link

@wluyima wluyima commented Oct 11, 2024 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@wluyima wluyima changed the title #707 Add support to skip the logout confirmation in the auth provider 707 Add support to skip the logout confirmation in the auth provider Oct 11, 2024
@wluyima wluyima changed the title 707 Add support to skip the logout confirmation in the auth provider Add support to skip the logout confirmation in the auth provider Oct 11, 2024
@sbidoul
Copy link
Member

sbidoul commented Oct 12, 2024

@wluyima This sounds useful. I'm not convinced with storing the id token on the user, if only because it won't be compatible with oauth_oauth_muti_token. Would it possible to obtain the id token on demand?

@wluyima
Copy link
Author

wluyima commented Oct 14, 2024

I'm not sure how multi tokens are handled in the auth provider, the addon currently also stores the access_token in the user table, so multi tokens would affect it too. My guess is that when a user logs out, the auth provider ends all their sessions for that particular client implying that as long I have one of the id tokens it would still end all their sessions across all tokens but I will do some research on this.

I'd guess it should be possible to fetch the id_token using the token_endpoint because that's its purpose.

@wluyima
Add support to skip the logout confirmation in the auth provider
2db2173 
Add field to oauth provider to toggle skip logout confirmation

Added tests for the skip confirmation feature

Applied auto format changes

Removed unused line

Reduced long line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wluyima @OCA-git-bot @sbidoul