Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][WIP] sale_payment_sheet: Define @freeze_time decorator in tests and not in TestSaleInvoicePayment to avoid side effects #3606

Closed

Conversation

victoralmau
Copy link
Member

Define @freeze_time decorator in tests and not in TestSaleInvoicePayment to avoid side effects

If a module (sale_payment_sheet_financial_risk for example) has a test https://github.com/OCA/credit-control/blob/120b39c8d92e856159d79ca084e69dd0d9c6badd/sale_payment_sheet_financial_risk/tests/test_sale_payment_sheet_financial_risk.py#L9 that extends it, a crash occurs in post tests

@Tecnativa

…not in TestSaleInvoicePayment to avoid side effects

If a module (sale_payment_sheet_financial_risk for example) has a test https://github.com/OCA/credit-control/blob/120b39c8d92e856159d79ca084e69dd0d9c6badd/sale_payment_sheet_financial_risk/tests/test_sale_payment_sheet_financial_risk.py#L9 that extends it, a crash occurs in post tests
@OCA-git-bot
Copy link
Contributor

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

@victoralmau
Copy link
Member Author

Added in #3595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants