Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] [MIG] sale_order_revision: Migration to 18.0 #3521

Open
wants to merge 31 commits into
base: 18.0
Choose a base branch
from

Conversation

bizzappdev
Copy link
Contributor

Dependency MR for module base_revision OCA/server-ux#986

@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_order_revision-BAD branch from c7f7154 to 3ddde3b Compare January 1, 2025 07:16
@bizzappdev bizzappdev marked this pull request as ready for review January 1, 2025 07:26
Copy link

@rjaraspearhead rjaraspearhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be fine for me.
Please. squash translation commits according to this guide

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_order_revision-BAD branch from 3ddde3b to e03e62e Compare January 23, 2025 06:02
@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_order_revision-BAD branch from e03e62e to 3ddde3b Compare February 10, 2025 11:30
rvalyi and others added 24 commits February 10, 2025 17:04
* extract description from __openerp__.py
* move things according to standard OCA layout
* reformatting
* port to new API
* Major rewrite of the 7.0 version:

  * the name of the SO is kept, and a revision number is appended
  * old revisions are made inactive
  * rewrite the copy logic

* update translations, added en.po fr.po
* fix typo in README
* use post_init_hook
* more assertions in the test
* sale_order_revision: remove en.po
* current_revision is only visible for non current revisions
* Fix create revision and improve view invisibility
* Fix unrevisioned name and improve test
wrong keyword name in SaleOrder.copy definition
was breaking sale order duplication
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/de/
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/zh_CN/
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/es/
[13.0] fix pre-commit + formatting

add test lines and linting xml
@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_order_revision-BAD branch from 3ddde3b to d04e761 Compare February 10, 2025 11:35
Copy link

@JessBrandl JessBrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested in runboat and works as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.