[ADD][16.0] Sale Margin Update #3374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrebollo
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Hi @ljimenezsidoo great to see your contribution. You are proposing a new addon so I would prefer make a deeper description of PR's digging on the specific requirement is trying to fulfill, comparing maybe with standard behavior or whether it is possible with a functional approach to address the real issue. If You clarify those points I think will be more helpful to understand what is this about. Maybe U can tag me then. Thank U.
ljimenezsidoo
force-pushed
the
16.0-add_sale_margin_update
branch
from
c5e288e
to
d844045
Compare
FIX requested changes ADD test
ljimenezsidoo
force-pushed
the
16.0-add_sale_margin_update
branch
from
d844045
to
cf1e13b
Compare
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds a wizard that enables users to recalculate the unit price of products on a sale order line based on a specified margin percentage. It allows recalculating the sale price dynamically to ensure the desired profit margin is achieved.
Margin-based Price Adjustment: Users can specify a margin percentage to calculate and set the product's sale price according to that margin.
Negative and High Margin Constraints: The module includes validation to prevent negative margins and margins equal to or greater than 100%.