[16.0][FIX] sale_order_product_picker: Changes not saved when line is already saved

[CarlosRoca13]

This PR solves the issue reported on #2794

cc @Tecnativa

ping @yajo @rafaelbn

[yajo]

@rafaelbn @Gelojr please review. @moduon MT-3930

[Gelojr]

LGTM
https://www.loom.com/share/ff5a17456abd4e5ca6960bcd552eebbf?sid=38c9b40f-9567-487d-97bf-bd16b27a48aa

[Shide]

LGTM

[yajo]

The problem with this fix is that it turns the button slower.

For example, if you want to add 3 units and click the button 3 times quickly, chances are that only 1 or 2 of those clicks are actually handled.

I think it would make sense to throttle and defer the calls, and only when the user has stopped clicking for about 500ms, then upload the changes. Does that make sense?

Otherwise, at least it would help if the button appears as disabled while you can't use it. That visual feedback isn't the best, but at least gives a hint that you have to wait to click more.

[yajo]

Hi @CarlosRoca13. Have you been able to review #2796 (review)? Any thoughts about it?

[CarlosRoca13]

Yes it's true, that some clicks are lost, but right now I have no chance to make the change, sorry 🙏

I will review it when I have a chance

[rafaelbn]

@yajo could we merge this as is and later propose a new PR? O better to propose a new PR directly?

I would like to close this task 😄

#2796

@moduon MT-4423

[yajo]

OK, let's merge. The new bug is better than the older one. I'll open a new issue about the new bug, so we can track it.

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2796-by-yajo-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at cbe3ece. Thanks a lot for contributing to OCA. ❤️

[yajo]

New issue opened in #2842