Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_restricted_qty #2708

Merged
merged 19 commits into from
May 18, 2024
Merged

[MIG] sale_restricted_qty #2708

merged 19 commits into from
May 18, 2024

Conversation

SirAionTech
Copy link
Contributor

@SirAionTech SirAionTech commented Oct 4, 2023 •
edited
Loading

@SirAionTech SirAionTech marked this pull request as ready for review October 4, 2023 08:04
dcorio
dcorio approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@dcorio dcorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
tested and working as expected

@thinkwelltwd
Copy link

thinkwelltwd commented Oct 9, 2023 •
edited
Loading

For whatever it's worth, #2581 is a v15 PR with numerous code linting improvements and grammatical fixes.

Personally, I'd be glad if that could be the basis for a future iterations of this module, if the code owner decides to merge it.

@rafaelbn
Copy link
Member

/ocabot migration sale_restricted_qty

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 23, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#2215) has not been updated to reference the current pull request because a previous pull request (#2757) is not closed.
Perhaps you should check that there is no duplicate work.
CC @sbiosca-s73

@rafaelbn rafaelbn mentioned this pull request Apr 23, 2024
Open
@rafaelbn
Copy link
Member

/ocabot rebase

mourad-ehm and others added 19 commits April 23, 2024 09:52
@mourad-ehm @OCA-git-bot
[IMP] rename module sale_order_min_qty to sale_restricted_qty
dcddd6d
@mourad-ehm @OCA-git-bot
[FIX] Update Readme & "use_parent" value to manual_force_sale_min_qty…
ce5344d 
… and manual_force_sale_max_qty (imp user UI)
@mourad-ehm @OCA-git-bot
[IMP] views & fix is_qty_less_min_qty & is_qty_bigger_max_qty
df86d2b
@mourad-ehm @OCA-git-bot
[IMP] add _get_sale_restricted_qty on sale to make qty overridable by…
1fbc137 
… other module & pep8
@mourad-ehm @OCA-git-bot
[FIX] _compute_sale_restricted_qty
9a2059d
@mourad-ehm @OCA-git-bot
[FIX] restricted_qty UserError Message
a6afa29
@mourad-ehm @OCA-git-bot
[FIX] openupgradelib requirements.txt
c7a31c0
@sebastienbeau @OCA-git-bot
[REF] refactor code to make it simplier and inheritable
b8061e3
@mourad-ehm @OCA-git-bot
[FIX] _compute_is_qty_less bigger multiple qty
475f9f0
@SicurSam @OCA-git-bot
Added translation using Weblate (Italian)
acca562
@AshishHirapara @OCA-git-bot
[14.0][MIG] sale_restricted_qty: Migration to 14.0
63d6f2b
@francesco-ooops @OCA-git-bot
Translated using Weblate (Italian)
acb6e7a 
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
@ilyasProgrammer @OCA-git-bot
[IMP] sale_restricted_qty: show sale_min sale_max optionally
142e9ac
@victoralmau @OCA-git-bot
[IMP] sale_restricted_qty: Change dp.get_precision digits
97cc911
@francesco-ooops @OCA-git-bot
Translated using Weblate (Italian)
67981ee 
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
@OCA-git-bot
Added translation using Weblate (French)
ea2e5dd
@mymage @OCA-git-bot
Translated using Weblate (Italian)
4ba9d5c 
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
@SirAionTech @OCA-git-bot
[IMP] sale_restricted_qty: pre-commit execution
765f093
@SirAionTech @OCA-git-bot
[MIG] sale_restricted_qty: Migration to 16.0
24be3f2
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

antoniocanovas
antoniocanovas approved these changes May 8, 2024
View reviewed changes
Copy link

@antoniocanovas antoniocanovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fucntional review Ok !

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedroguirao
pedroguirao approved these changes May 8, 2024
View reviewed changes
Copy link

@pedroguirao pedroguirao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dreispt
Copy link
Member

dreispt commented May 18, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2708-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6f5434e into OCA:16.0 May 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ef1e282. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroguirao pedroguirao pedroguirao approved these changes

@antoniocanovas antoniocanovas antoniocanovas approved these changes

@dcorio dcorio dcorio approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.