15.0 stock picking on hold #2608
Conversation
|
CI is failing because of another module "sale_order_discount_invoicing", for which tests are failing |
alihashaam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
f805485 to
25f135e
Compare
|
@alihashaam Thanks for this. IMHO, this has same functionality as https://github.com/OCA/sale-workflow/tree/15.0/sale_stock_picking_blocking As done in v16, the blocking reason is now computed stored. So, your module could depends on invoice_status field, then, assign the blocking reason. https://github.com/OCA/sale-workflow/blob/16.0/sale_stock_picking_blocking/models/sale_order.py#L33 What do you think ? |
|
@rousseldenis Thank you for the suggestion, it makes sense to base this module on |
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
d2c4c85 to
5d3806a
Compare
|
I don't think that test failure is related to this module stock_picking_on_hold. |
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
5d3806a to
40e579c
Compare
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
2 times, most recently
from
cc331f8 to
dc74d44
Compare
ortlam
force-pushed
the
15.0-stock_picking_on_hold
branch
from
c8fcad5 to
e03106f
Compare
|
@alihashaam What's the status of this ? |
jans23
force-pushed
the
15.0-stock_picking_on_hold
branch
2 times, most recently
from
fb533ce to
e990dde
Compare
|
@rousseldenis alihashaam isn't working on this anymore. I added missing tests. We use this module in production since more than a year and it's working fine. IMO it can be merged. |
| "depends": [ | ||
| "account_payment_mode", | ||
| "sale_stock_picking_blocking", | ||
| "website_sale", |
There was a problem hiding this comment.
IMHO, this is a too restrictive dependency as people do not want necessarily install website to get this functionality.
That part of code should be externalized in another module.
jans23
force-pushed
the
15.0-stock_picking_on_hold
branch
from
e990dde to
e439399
Compare
No description provided.