14.0 fix sale automatic workflow #2493
Conversation
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| { | |||
| "name": "Sale Automatic Workflow", | |||
| "version": "14.0.1.3.3", | |||
| "version": "14.0.1.2.0", | |||
There was a problem hiding this comment.
Don't change this. Automatically changed by ocabot
| @api.model | ||
| def default_get(self, fields): | ||
| res = super(SaleOrder, self).default_get(fields) | ||
| if "workflow_process_id" in fields: |
There was a problem hiding this comment.
Shouldn't it be :
| if "workflow_process_id" in fields: | |
| if "workflow_process_id" in fields and "workflow_process_id" not in res: |
| @@ -46,12 +49,12 @@ def _do_send_order_confirmation_mail(self, sale): | |||
| sale._send_order_confirmation_mail() | |||
|
|
|||
| @api.model | |||
| def _validate_sale_orders(self, order_filter): | |||
| def _validate_sale_orders(self, order_filter, auto_commit=False, limit=None): | |||
There was a problem hiding this comment.
To avoid passing the auto_commit parameter at each function, shouldn't it be better to get the auto_commit value from the sale order workflow directly?
So in the iteration loop on sales:
sale.workflow_process_id.auto_commit
ChrisOForgeFlow
force-pushed
the
14.0-fix-sale_automatic_workflow
branch
from
efa24d7 to
8f8754a
Compare
JordiBForgeFlow
force-pushed
the
14.0-fix-sale_automatic_workflow
branch
2 times, most recently
from
1f329b9 to
f05a5c7
Compare
|
/ocabot rebase |
|
@rousseldenis The rebase process failed, because command |
|
I was not involved in this one. @AlexPForgeFlow maybe you have some insight? |
|
@rousseldenis were you just trying to rebase or is there any pending review or change to do? |
Yes a rebase should be great. |
|
@rousseldenis I have no permissions to push on origin branch, I have asked @JordiBForgeFlow |
JordiBForgeFlow
force-pushed
the
14.0-fix-sale_automatic_workflow
branch
from
f05a5c7 to
b6972cb
Compare
|
@rousseldenis Rebased! |
|
@JordiBForgeFlow Could you check tests ? |
|
@rousseldenis I will take a look! |
|
Hi @rousseldenis ! I have open a new PR #3587 to continue this one and get test fixed |
Reference: #1514