-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] sale_order_qty_change_no_recompute: Migration to version 16.0 #2473
[16.0][MIG] sale_order_qty_change_no_recompute: Migration to version 16.0 #2473
Conversation
0e64cc1
to
97cb12c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that the previous code is not working. Isn't it?
c71a103
to
e062f94
Compare
/ocabot migration sale_order_qty_change_no_recompute |
…uantity has changed in sale order line
…hange The _origin trick is not valid, as it doesn't reflect the state before the onchange, only the saved copy (if any).
e062f94
to
34664e9
Compare
…ent onchange quantity and some possible related error in another addons.
Changing that field shouldn't trigger price recomputation as well. TT32663
- Standard procedure - Change the strategy, as now the change is done through a computed field. - Improved README
34664e9
to
bfc0c03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to a new approach to get the feature covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review.
👍
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 932b90c. Thanks a lot for contributing to OCA. ❤️ |
ping @Juangomezzurita |
@Tecnativa TT42279