Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_order_qty_change_no_recompute: Migration to version 16.0 #2473

Merged

Conversation

Yadier-Tecnativa
Copy link
Contributor

@Tecnativa TT42279

@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_qty_change_no_recompute branch 3 times, most recently from 0e64cc1 to 97cb12c Compare April 11, 2023 18:47
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the previous code is not working. Isn't it?

sale_order_qty_change_no_recompute/models/sale_order.py Outdated Show resolved Hide resolved
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_qty_change_no_recompute branch 2 times, most recently from c71a103 to e062f94 Compare April 12, 2023 17:01
@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_qty_change_no_recompute

@OCA-git-bot
Copy link
Contributor

The migration issue (#2215) has been updated to reference the current pull request.
however, a previous pull request was referenced : #2365.
Perhaps you should check that there is no duplicate work.
CC : @ignissak

@pedrobaeza pedrobaeza force-pushed the 16.0-mig-sale_order_qty_change_no_recompute branch from e062f94 to 34664e9 Compare May 1, 2023 19:48
victoralmau and others added 5 commits May 1, 2023 21:49
…ent onchange quantity and some possible related error in another addons.
Changing that field shouldn't trigger price recomputation as well.

TT32663
- Standard procedure
- Change the strategy, as now the change is done through a computed
  field.
- Improved README
@pedrobaeza pedrobaeza force-pushed the 16.0-mig-sale_order_qty_change_no_recompute branch from 34664e9 to bfc0c03 Compare May 1, 2023 19:49
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a new approach to get the feature covered.

Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review.
👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2473-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b33ea48 into OCA:16.0 May 7, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 932b90c. Thanks a lot for contributing to OCA. ❤️

@sergio-teruel
Copy link
Contributor

ping @Juangomezzurita
Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants