Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] sale_loyalty_multi_gift: Migration to 17.0 #249

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from

Conversation

chienandalu and others added 14 commits January 23, 2025 13:08
Now we use the product field in the multi gift line as a mask for a
many2many field that can be used by a third module as a way to offer
optional gifts to the user.

TT30850
When we've got mixed optional rewards
we need to tell for sure which reward
line belongs a sale line to so we can
apply the right product when the reward
is updated.

TT34266
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_multi_gift
Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_multi_gift/es/
Currently translated at 100.0% (26 of 26 strings)

Translation: sale-promotion-16.0/sale-promotion-16.0-sale_loyalty_multi_gift
Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-16-0/sale-promotion-16-0-sale_loyalty_multi_gift/it/
@rousseldenis
Copy link

@HeliconiaSolutions When you depend on pending PR's, it is better to embed them here to:

  • Make tests running
  • Make runboat running

That in order to help reviewers (technical and functional).

See: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@rousseldenis
Copy link

/ocabot migration sale_loyalty_multi_gift

@HeliconiaSolutions
Copy link
Author

@HeliconiaSolutions When you depend on pending PR's, it is better to embed them here to:

  • Make tests running
  • Make runboat running

That in order to help reviewers (technical and functional).

See: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Hi @rousseldenis ,

Thank you for your review! I’m reaching out regarding the process outlined in OCA Maintainer Tools. I attempted to follow the guidelines for using temporary references to another PR but am struggling to fully understand the concept and steps involved.

Could you please provide a detailed explanation or some guidance on how to correctly apply this to update my PR (#249)? Any examples or best practices would be greatly appreciated, as I want to ensure I follow the correct process and adhere to the OCA standards.

Thanks in advance for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants