[17.0][MIG] sale_loyalty_order_line_link: Migration to 17.0

sale_loyalty_order_line_link/README.rst

@@ -85,6 +85,8 @@ Contributors
 
   - Ilyas
 
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+
 Maintainers
 -----------
 

sale_loyalty_order_line_link/__manifest__.py

@@ -4,7 +4,7 @@
     "name": "Link loyalty programs to order lines",
     "summary": "Adds a link between loyalty programs and their generated order lines"
     "for easing tracking",
-    "version": "16.0.1.0.1",
+    "version": "17.0.1.0.0",
     "development_status": "Production/Stable",
     "category": "Sale",
     "website": "https://github.com/OCA/sale-promotion",

sale_loyalty_order_line_link/readme/CONTRIBUTORS.md

@@ -3,3 +3,4 @@
   - Pilar Vargas
 - [Ooops404](https://www.ooops404.com):
   - Ilyas
+- \[Heliconia Solutions Pvt. Ltd.\](<https://www.heliconia.io>)

sale_loyalty_order_line_link/static/description/index.html

@@ -434,6 +434,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <li>Ilyas</li>
 </ul>
 </li>
+<li>[Heliconia Solutions Pvt. Ltd.](<a class="reference external" href="https://www.heliconia.io">https://www.heliconia.io</a>)</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

sale_loyalty_order_line_link/tests/test_sale_loyalty_order_line_link.py

@@ -188,3 +188,27 @@ def test_03_coupon_order_line_link_product(self):
         self.assertTrue(line_c.reward_line_ids)
         self.assertEqual(line_a.reward_generated_line_ids, reward_line)
         self.assertFalse(line_b.reward_generated_line_ids)
+
+    def test_04_select_additional_fields(self):
+        # Call the _select_additional_fields method
+        sale_report = self.env["sale.report"]
+        fields = sale_report._select_additional_fields()
+
+        # Assert that the loyalty_program_id field is included
+        self.assertIn(
+            "l.loyalty_program_id",
+            fields.values(),
+            "The 'loyalty_program_id' field is not added to the select statement.",
+        )
+
+    def test_05_group_by_sale(self):
+        # Call the _group_by_sale method
+        sale_report = self.env["sale.report"]
+        group_by_fields = sale_report._group_by_sale()
+
+        # Assert that 'l.loyalty_program_id' is included in the GROUP BY clause
+        self.assertIn(
+            "l.loyalty_program_id",
+            group_by_fields,
+            "The 'loyalty_program_id' field is not included in the GROUP BY clause.",
+        )

sale_loyalty_order_line_link/views/sale_order_views.xml

@@ -5,12 +5,12 @@
         <field name="inherit_id" ref="sale.view_order_form" />
         <field name="arch" type="xml">
             <xpath expr="//page[@name='other_information']" position="inside">
-                <group attrs="{'invisible': [('applied_coupon_ids', '=', [])]}">
+                <group invisible="applied_coupon_ids == []">
                     <group name="promo_info" string="Promotions">
                         <field
                             name="applied_coupon_ids"
                             readonly="True"
-                            attrs="{'invisible': [('applied_coupon_ids', '=', [])]}"
+                            invisible="applied_coupon_ids == []"
                             widget="many2many_tags"
                         />
                     </group>