[IMP] add field channel_type on sale.channel

[clementmbr]

Useful fields for the Amazon connector!

[florian-dacosta]

LGTM but you need to add these in the view, no ?

[clementmbr]

@florian-dacosta I'm thinking now that it may be better to add these fields in the sale_import_base module... What do you prefer?

[clementmbr]

@florian-dacosta I finally chose to put only channel_type in the base module sale_channel as I thought company_id or crm_team_id are more Import Parameters to be transferred to the new sale.order

[bealdav]

LGTM

[adrienpeiffer]

LGTM

[rousseldenis]

@sebastienbeau @clementmbr Could you check why connector_search_engine make tests red ?

[timloic]

That make sense

[clementmbr]

@sebastienbeau @clementmbr Could you check why connector_search_engine make tests red ?

Hi @rousseldenis, as you can see it's red because connector_search_engine is loading the external dependency typing_extensions which is not in the module's manifest.

I can open a PR on the search-engine repo to add the external dependency, but I wonder why, if this is the problem, there is no other broken tests on the repo.

Is it possible to re-run the tests first to see it can pass?
Thanks!

[clementmbr]

@rousseldenis @florian-dacosta @bealdav with OCA/search-engine#194 merged, this PR can be merged!

Thanks!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[rvalyi]

/ocabot merge minor

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-17-by-rvalyi-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 79664aa. Thanks a lot for contributing to OCA. ❤️