Skip to content

Commit

Permalink
[IMP] fastapi: detail to have exception message if fastapi dev_mode e…
Browse files Browse the repository at this point in the history
…nabled
  • Loading branch information
viktor-anikeenko-avsys committed Nov 12, 2024
1 parent f89d54d commit d5dd7ac
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion fastapi/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"name": "Odoo FastAPI",
"summary": """
Odoo FastAPI endpoint""",
"version": "17.0.3.0.1",
"version": "17.0.4.0.0",
"license": "LGPL-3",
"author": "ACSONE SA/NV,Odoo Community Association (OCA)",
"maintainers": ["lmignon"],
Expand Down
6 changes: 6 additions & 0 deletions fastapi/error_handlers.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Copyright 2022 ACSONE SA/NV
# License LGPL-3.0 or later (http://www.gnu.org/licenses/LGPL).

import traceback

from starlette import status
from starlette.exceptions import HTTPException, WebSocketException
from starlette.middleware.errors import ServerErrorMiddleware
Expand All @@ -10,6 +12,7 @@
from werkzeug.exceptions import HTTPException as WerkzeugHTTPException

from odoo.exceptions import AccessDenied, AccessError, MissingError, UserError
from odoo.tools import config

from fastapi import Request
from fastapi.encoders import jsonable_encoder
Expand All @@ -21,6 +24,9 @@ def convert_exception_to_status_body(exc: Exception) -> tuple[int, dict]:
body = {}
status_code = status.HTTP_500_INTERNAL_SERVER_ERROR
details = "Internal Server Error"
if config.get_misc("fastapi", "dev_mode"):
tb = "".join(traceback.format_exception(exc))
details = f"{details}\n{tb}"

Check warning on line 29 in fastapi/error_handlers.py

View check run for this annotation

Codecov / codecov/patch

fastapi/error_handlers.py#L28-L29

Added lines #L28 - L29 were not covered by tests

if isinstance(exc, WerkzeugHTTPException):
status_code = exc.code
Expand Down

0 comments on commit d5dd7ac

Please sign in to comment.