-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branch 18.0 [WAIT FOR MERGE] #36
Conversation
I still have to address the use case to reuse answers from previous branch OCA/maintainer-tools#541 |
And this should wait until we update the configurations for this new branch. |
Agree, see OCA/maintainer-tools#541 (comment) |
@simahawk can you explain how you this this PR in the PR description, as reference for the future? |
Sure, I'll also improve the README of the tool. |
8f94733
to
dee8ad7
Compare
@simahawk I have already switched default branch of OCB to 18.0 FYI in a direct commit for continuing with the rest of the needed changes for the foundation. |
I suggest making a PR that creates the 18 branch on a couple of repos first, where someone is ready to do a PR to test the repo template. |
Rebased |
FTR v18 branch tested on server-env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to switch the default branch for all the repos to version 18?
I'm not sure. It would give the impression of empty repos everywhere in OCA. |
It was in the checklist 😉
Yes, same feeling here. Yet, this is true even when you have 1 single module migrated :) Personally I don't mind. I can roll back this change. What do you prefer? We should probably improve the readme of the repos by including a message and a link to pull requests. |
@pedrobaeza @sbidoul there you go #41 |
Addresses v18 checklist OCA/maintainer-tools#628
How to obtain this result? Easy w/ OCA/repo-maintainer#20
That's it.
WAIT FOR MERGE TILL REST OF THE TOOLS ARE READY