Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some PSC and missing report-print-send #3

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

simahawk
Copy link
Contributor

Fix some PSC and missing report-print-send

Fixes #2

Meanwhile, branch 17.0 has been created for some repos.

Fix some PSC and missing report-print-send

Fixes OCA#2
@etobella
Copy link
Member

The problem comes from not setting the force and push to the repo. For that, we need to do the following:

  1. [FIX] Allow to force repo-maintainer#16
  2. Modify the action so it commits and pushes the modified file. We can also modify the repo-maintainer to push it, but that might be dirty 🤔

@etobella
Copy link
Member

We can use this: https://github.com/stefanzweifel/git-auto-commit-action

But I would like to obtain some comments first:

@simahawk @sbidoul

@etobella
Copy link
Member

Oops, Yes, we need to merge this changes, as the information is not correctly processed. Anyway, i think we need to apply the proposed changes if possible.

@simahawk
Copy link
Contributor Author

@etobella I'm not sure to understand how this is related to this issue. Here we just had wrong conf from bootstrap_data. And I fixed it. For the conf to be correct we just need to merge this PR.

@simahawk
Copy link
Contributor Author

The problem w/ the build is another story #1

@simahawk simahawk merged commit ca9dae1 into OCA:master Nov 19, 2023
1 check passed
@simahawk simahawk deleted the test-oca-repos branch November 19, 2023 13:30
@etobella
Copy link
Member

I know, I misplaced the comment. Here we can find an issue we need to solve by merging it.

However, you applied a change on repo-maintainer that would allow us to use less connections by keeping the checksum of files. My proposal was related to that.

@simahawk
Copy link
Contributor Author

simahawk commented Nov 19, 2023

I know, I misplaced the comment. Here we can find an issue we need to solve by merging it.

However, you applied a change on repo-maintainer that would allow us to use less connections by keeping the checksum of files. My proposal was related to that.

Ahh, I see now. We "just" forgot to add an automatic commit to update the checksum of the files 💡

@simahawk
Copy link
Contributor Author

I created #4 to follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong PSC conf for some repos
2 participants