[FIX] pylint_odoo: Fix parsing dictionary from manifest #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
fix-dict-parser-moy
branch
from
210fddc to
b0bec7e
Compare
The following code:
- `# e.g. {"key": "" or ""}`
It is parsed correctly the node code
But `ast.literal_eval` shows the following traceback:
```txt
Exception on node <Dict.dict l.3 at 0x10ef6aba0>
Traceback (most recent call last):
File "pylint/utils/ast_walker.py", line 91, in walk
callback(astroid)
~~~~~~~~^^^^^^^^^
File "pylint_odoo/checkers/odoo_addons.py", line 1034, in visit_dict
manifest_dict = ast.literal_eval(node.as_string())
File "3.13/lib/python3.13/ast.py", line 114, in literal_eval
return _convert(node_or_string)
File "3.13/lib/python3.13/ast.py", line 103, in _convert
return dict(zip(map(_convert, node.keys),
map(_convert, node.values)))
File "3.13/lib/python3.13/ast.py", line 113, in _convert
return _convert_signed_num(node)
File "3.13/lib/python3.13/ast.py", line 87, in _convert_signed_num
return _convert_num(node)
File "3.13/lib/python3.13/ast.py", line 78, in _convert_num
_raise_malformed_node(node)
~~~~~~~~~~~~~~~~~~~~~^^^^^^
File "3.13/lib/python3.13/ast.py", line 75, in _raise_malformed_node
raise ValueError(msg + f': {node!r}')
ValueError: malformed node or string on line 1: <ast.BoolOp object at 0x1104df790>
````
moylop260
force-pushed
the
fix-dict-parser-moy
branch
from
b0bec7e to
824468f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code:
{"key": "" or ""}It is parsed correctly the node code
But
ast.literal_evalshows the following traceback:Exception on node <Dict.dict l.3 at 0x10ef6aba0> Traceback (most recent call last): File "pylint/utils/ast_walker.py", line 91, in walk callback(astroid) ~~~~~~~~^^^^^^^^^ File "pylint_odoo/checkers/odoo_addons.py", line 1034, in visit_dict manifest_dict = ast.literal_eval(node.as_string()) File "3.13/lib/python3.13/ast.py", line 114, in literal_eval return _convert(node_or_string) File "3.13/lib/python3.13/ast.py", line 103, in _convert return dict(zip(map(_convert, node.keys), map(_convert, node.values))) File "3.13/lib/python3.13/ast.py", line 113, in _convert return _convert_signed_num(node) File "3.13/lib/python3.13/ast.py", line 87, in _convert_signed_num return _convert_num(node) File "3.13/lib/python3.13/ast.py", line 78, in _convert_num _raise_malformed_node(node) ~~~~~~~~~~~~~~~~~~~~~^^^^^^ File "3.13/lib/python3.13/ast.py", line 75, in _raise_malformed_node raise ValueError(msg + f': {node!r}') ValueError: malformed node or string on line 1: <ast.BoolOp object at 0x1104df790>