[ADD] checkers: category-allowed #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I like this new lint since the default values are empty so it could be enabled explicitly but disable implicitly So 👍 @luisg123v could you review it, please? |
luisg123v
suggested changes
May 24, 2023
| "type": "csv", | ||
| "metavar": "<comma separated values>", | ||
| "default": DFTL_CATEGORY_ALLOWED, | ||
| "help": "List of category allowed in manifest file, separated by a comma.", |
There was a problem hiding this comment.
Suggested change
| "help": "List of category allowed in manifest file, separated by a comma.", | |
| "help": "List of allowed categories in manifest file, separated by commas.", |
| @@ -1007,6 +1019,17 @@ def visit_dict(self, node): | |||
| if license_str and license_str not in self.linter.config.license_allowed: | |||
| self.add_message("license-allowed", node=manifest_keys_nodes.get("license") or node, args=(license_str,)) | |||
|
|
|||
| # Check category allowed | |||
| category_str = manifest_dict.get("category", None) | |||
There was a problem hiding this comment.
Superfluous default value for get
|
Also, could you add a unittest, please? |
|
|
Will you able to re-take this work? |
|
@ThomasBinsfeld gentle nudge |
ThomasBinsfeld
force-pushed
the
add_pylint_odoo_checker_category_allowed_tbi
branch
2 times, most recently
from
ce6aa80 to
e41a5cf
Compare
New check allowing to enforce the allowed Odoo modules categories. A list of coma-separated categories can be set under the category-allowed setting.
ThomasBinsfeld
force-pushed
the
add_pylint_odoo_checker_category_allowed_tbi
branch
from
e41a5cf to
f8b5c6c
Compare
|
Branch rebased and tests added ✔️ |
baimont
approved these changes
Nov 7, 2023
jdoutreloux
approved these changes
Nov 7, 2023
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.