[FIX] Exclude missing-return checks for computed methods #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luisg123v can you review? thanks |
luisg123v
suggested changes
Jan 7, 2023
| # compute method names must be stored to avoid false positives if super is called inside them | ||
| if self.linter.is_message_enabled("missing-return"): | ||
| if hasattr(node, "keywords"): | ||
| for keyword in node.keywords: |
There was a problem hiding this comment.
Suggested change
| for keyword in node.keywords: | |
| for keyword in getattr(node, "keywords", []): |
That way, you don't need the above conditional, so you may avoid an extra indentation level.
Or in fault, combine the two conditionals above
There was a problem hiding this comment.
That's nice, I made the change and also added a break once the compute attribute is found since there is no use in looking for a second one AFAIK.
Fixes OCA#450. Compute methods are not supposed to return any value, even if there is a super() in it, since super() shouldn't return anything either. The only reliable way to ensure a field is computed is if has been declared in the same python module (file), so this exclusion only applies to a limited set of cases.
luisg123v
suggested changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450. Compute methods are not supposed to return any value, even if there is a super() in it, since super() shouldn't return anything either.
The only reliable way to ensure a field is computed is if has been declared in the same python module (file), so this exclusion only applies to a limited set of cases.