[17.0][MIG] purchase_blanket_order #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnauCForgeFlow
force-pushed
the
17.0-mig-purchase_blanket_order
branch
2 times, most recently
from
6deab97
to
dcafda2
Compare
| "summary": "Purchase Blanket Orders", | ||
| "depends": [ | ||
| "purchase", | ||
| "web_action_conditionable", |
There was a problem hiding this comment.
Looking at the module, this dependency looks like it is not needed. Can you check if it is really the case? If not, we probably can get rid of it during this migration.
There was a problem hiding this comment.
You are right, I tested it and it looks like the module no longer needs this dependency. Removing it.
ArnauCForgeFlow
force-pushed
the
17.0-mig-purchase_blanket_order
branch
from
dcafda2
to
cb10dd7
Compare
ArnauCForgeFlow
force-pushed
the
17.0-mig-purchase_blanket_order
branch
from
cb10dd7
to
04c261e
Compare
The default behavior in a PO is that the purchsing UoM is used as the PO line UoM when set in the product. Blanket Orders should do the same, otherwise it is a bit confusing.
Currently translated at 100.0% (150 of 150 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/
Currently translated at 100.0% (151 of 151 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/
Currently translated at 100.0% (153 of 153 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/it/
Currently translated at 100.0% (153 of 153 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/es/
ArnauCForgeFlow
force-pushed
the
17.0-mig-purchase_blanket_order
branch
from
04c261e
to
67f1910
Compare
ArnauCForgeFlow
force-pushed
the
17.0-mig-purchase_blanket_order
branch
from
67f1910
to
961de26
Compare
|
@HviorForgeFlow solved! |
LoisRForgeFlow
suggested changes
Sep 16, 2024
Hey @LoisRForgeFlow The confirmation message is generated in purchase_request module, and there is an existing pr solving this problem: |
LoisRForgeFlow
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks @ArnauCForgeFlow I tested the wrong module 🤣
This time I reviewed blanket order, functional review is good 👍
HviorForgeFlow
approved these changes
Sep 19, 2024
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b193ea8. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard Migration to 17.0