Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] purchase_split_by_incoterm #2366

Open
wants to merge 5 commits into
base: 16.0
Choose a base branch
from

Conversation

mathieudelva
Copy link

No description provided.

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose purchase_split_by_incoterm is a more meaningful name
Check comment and faild test


def _make_po_get_domain(self, company_id, values, partner):
""" """
domain = super(StockRule, self)._make_po_get_domain(company_id, values, partner)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
domain = super(StockRule, self)._make_po_get_domain(company_id, values, partner)
domain = super()._make_po_get_domain(company_id, values, partner)

@bealdav
Copy link
Member

bealdav commented Jul 18, 2024

Please could you edit PR name, thanks for this work

@rvalyi rvalyi changed the title [16.0][ADD] purchase_order_incoterm [16.0][ADD] purchase_split_by_incoterm Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants