[IMP] purchase_lot : lot_id is computed from stock moves so that it c…

[metaminux]

…an be updated after confirmation and purchase order lines aren't merged even if lots aren't defined at creation

As sale_order_lot_selection allows to change lot after confirmation, we think stock moves and related objects should propagate those changes (here purchase order lines)

This PR is linked to these others PRs :

• [16.0][IMP][stock_restrict_lot] propagation of restrict_lot changes stock-logistics-workflow#1560
• [16.0][IMP][sale_order_lot_selection] allow or not change of lot_id  sale-workflow#3057

[OCA-git-bot]

Hi @florian-dacosta,
some modules you are maintaining are being modified, check this out!

[metaminux]

Hi @florian-dacosta

Now that OCA/stock-logistics-workflow#1560 has been merged, can we process this one too ?

Regards,

[florian-dacosta]

@metaminux I don't really like this because the lot on the purchase line could change anytime silently, no matter the state of the purchase order.

In most cases (or at least in some cases), we want the lot on the purchase so we can send it (+ eventually information stored on the lot) to the supplier, so that it can send a product accordingly.
If the purchase order is already validated or even "sent", and the lot change, you probably want to inform your supplier (maybe by EDI, mail, phone or whatever).
It does not help to change the lot in Odoo if we do not inform the supplier.

I would be ok to change the lot if the purchase is still at draft state, but otherwise, I'd rather not.

[metaminux]

Hi @florian-dacosta

You're right, maybe I'm too focused on my specific use case which is inter company workflow...
It seems to me that selling a specific lot that we need to purchase implies tight communication with the supplier.

I can only imagine 2 use cases here :

• you are defining the lots/serial numbers your supplier will put on the products you are buying
• your supplier give you the list of lots/serial number he will send to you at early stage and you are dispatching those numbers in your sale orders

In first case, I suppose you are generating lots before confirming the sale order and you don't want to change it after (which is the behaviour we got for the moment)
In second case, your supplier gives you lots after the purchase has been confirmed, so we need to propagate changes from sale to purchase.

Now, in first case, if we change the lots after confirmation, it can be just switching between sales or you need to inform your supplier you want some new lots...

Of course, I could be wrong about use cases here, so feel free to correct me.