Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] pos_disable_product_variant #970

Closed
wants to merge 1 commit into from
Closed

[16.0][ADD] pos_disable_product_variant #970

wants to merge 1 commit into from

Conversation

ecino
Copy link
Contributor

@ecino ecino commented Apr 14, 2023

New module for excluding specific variants from Point of Sale.

@ecino ecino force-pushed the 16.0-pos_disable_product_variant branch 4 times, most recently from f87a003 to b86f861 Compare April 14, 2023 10:12
@ecino
Copy link
Contributor Author

ecino commented Apr 14, 2023

Apparently the module breaks the test of pos_order_to_sale_order. But those are Javascript tests for which I have no clue. Can anyone help on this?

@ecino
Copy link
Contributor Author

ecino commented Jun 29, 2023

Can someone review this one please?

@legalsylvain legalsylvain added this to the 16.0 milestone Sep 26, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 28, 2024
@ecino ecino force-pushed the 16.0-pos_disable_product_variant branch from 5a00394 to 74f7b67 Compare January 29, 2024 10:56
@ecino
Copy link
Contributor Author

ecino commented Jan 29, 2024

@OCA/pos-maintainers Anyone willing to review?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
ivantodorovich
ivantodorovich approved these changes Jul 3, 2024
View reviewed changes
pos_disable_product_variant/models/product_product.py
records = super().create(vals_list)
# Activate variants in POS
records.filtered("available_in_pos").mapped("product_variant_ids").write(
{"available_in_pos": True}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to change the product.template field to a computed field with inverse and search.

Similar to how Odoo core treats the barcode, weight, volume, etc..

@ivantodorovich
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-pos_disable_product_variant branch from 74f7b67 to b26a73d Compare July 3, 2024 11:23
@ivantodorovich ivantodorovich removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 3, 2024
@ivantodorovich
Copy link
Contributor

Could you squash the [FIX] Change model_create_single decorator to multi commit?
It's not relevant to add it to the history, since this is a brand new module

@ecino
[16.0][ADD] pos_disable_product_variant
dbc2e3e 
New module for excluding specific variants from Point of Sale.
@ecino ecino force-pushed the 16.0-pos_disable_product_variant branch from b26a73d to dbc2e3e Compare July 4, 2024 07:55
@ecino
Copy link
Contributor Author

ecino commented Jul 4, 2024

Rebased and squashed.

@ivantodorovich
Copy link
Contributor

Thanks! It looks like the Ci is broken after the rebase.
Many tours are failing. Could you check?

@ivantodorovich
Copy link
Contributor

Hello @ecino,

I'm closing this PR due inactivity while the CI is broken
Feel free to re-open a new one

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
needs fixing needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ecino @ivantodorovich @OCA-git-bot @legalsylvain