-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][Add] pos_product_pricelist_alternative #1235
base: 16.0
Are you sure you want to change the base?
[16.0][Add] pos_product_pricelist_alternative #1235
Conversation
69095cb
to
97ad006
Compare
28ea3dd
to
c108114
Compare
fc2aba9
to
1e73ccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart the use of IMO unnecessary var
statement
1e73ccd
to
655ec88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG 👍🏻
It'd be super nice to add a simple test tour to test a product with an alternative price set 🙏🏻
I'm checking the red CI
@@ -0,0 +1,2 @@ | |||
POS product pricelist allternative is based on the same logic of `OCA/product_pricelist_alternative: <https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_alternative>` which allows you to define alternative price lists to a reference price list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POS product pricelist allternative is based on the same logic of `OCA/product_pricelist_alternative: <https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_alternative>` which allows you to define alternative price lists to a reference price list. | |
POS product pricelist alternative is based on the same logic of `OCA/product_pricelist_alternative: <https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_alternative>` which allows you to define alternative price lists to a reference price list. |
The same error happened on #1220. I forced running tests on 16.0 |
655ec88
to
36ee150
Compare
rebase should fix the CI. |
36ee150
to
03d4cd7
Compare
Done |
03d4cd7
to
025f7d9
Compare
POS product pricelist allternative is based on the same logic of OCA/product_pricelist_alternative which allows you to define alternative price lists to a reference price list.
As a general rule, the price of a given product is obtained from the minimum between its reference price list and the alternative price lists.