Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] pos_lot_barcode: fix testcase #1232

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[17.0][FIX] pos_lot_barcode: fix testcase #1232

merged 1 commit into from
Sep 18, 2024

Conversation

chaule97
Copy link

@chaule97 chaule97 commented Aug 26, 2024 •
edited
Loading

  • as reported in some PRs (#1208, #1230, #1234) pos_lot_barcode tests were failing due a tour.
  • turns out the root cause if that the pos_lot_selection and pos_product_expirymodules have the same test case class name as the pos_lot_barcode module.
  • as a consequence, there was a conflict during the unittest TestSuite collection process.
  • Beside, I add ProductScreen.confirmOpeningPopup() step in order to confirm the opening of the session.

@chaule97 chaule97 marked this pull request as draft August 26, 2024 08:49
@chaule97 chaule97 force-pushed the 17.0-fix-pos_lot_barcode branch 2 times, most recently from 4c4fd5b to 1c03558 Compare August 26, 2024 10:43
@chaule97 chaule97 marked this pull request as ready for review August 26, 2024 10:55
@chaule97 chaule97 marked this pull request as draft August 26, 2024 10:56
@chaule97 chaule97 force-pushed the 17.0-fix-pos_lot_barcode branch 4 times, most recently from 4a2d2ea to 2af3415 Compare August 27, 2024 08:52
@chaule97 chaule97 marked this pull request as ready for review August 27, 2024 09:08
@traitrantrobz traitrantrobz mentioned this pull request Aug 29, 2024
Open
@victorvermot victorvermot mentioned this pull request Sep 2, 2024
Merged
FernandoRomera
FernandoRomera approved these changes Sep 4, 2024
View reviewed changes
Copy link

@FernandoRomera FernandoRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@FernandoRomera FernandoRomera mentioned this pull request Sep 10, 2024
Merged
etobella
etobella approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1232-by-etobella-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 10, 2024
@OCA-git-bot
Merge PR #1232 into 17.0
d660147 
Signed-off-by etobella
@OCA-git-bot
Copy link
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1232-by-etobella-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Member

Well, it seems that the error is still raised after the changes 😭

ivantodorovich
ivantodorovich approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ivantodorovich
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1232-by-ivantodorovich-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d3c4277 into OCA:17.0 Sep 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eec62aa. Thanks a lot for contributing to OCA. ❤️

@chaule97 chaule97 mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoRomera FernandoRomera FernandoRomera approved these changes

@etobella etobella etobella approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chaule97 @OCA-git-bot @etobella @ivantodorovich @cyrilmanuel @FernandoRomera