-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] migrate pos_tare to 16.0 #1224
Open
robinkeunen
wants to merge
31
commits into
OCA:16.0
Choose a base branch
from
coopiteasy:16.0-mig-pos_tare
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADD] barcode nomenclature for tare [ADD] tare field on pos.order.line model [ADD] Tare button in PoS numpad [IMP] handle correctly different UoM [IMP] add warning at checkout if qty <=0 [IMP] display gross and tare weight for each line Co-authored-by: François Kawala <[email protected]> Co-authored-by: Sylvain LE GAL <[email protected]>
Currently translated at 100.0% (46 of 46 strings) Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
…antity in the correct place
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Currently translated at 100.0% (55 of 55 strings) Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/it/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at the migration from version 12 through 14 (#1206 ).
I'm having trouble testing the barcode behavior, how do you find out the check digit for an encoded tare barcode ?
Refactoring suggestion
The parameter
iface_gross_weight_method
lets you choose wether to input gross weight manually (manual
) or through the scale (scale
).manual
is selected andiface_electronic_scale
is false : you can enter the weight and tare through the numpad widgetmanual
is selected andiface_electronic_scale
is true : scale screen opens and you can input weight manually in the screen. The scale will never be read. => why open the scale screen if the scale is not read and everything can be done through the product screenscale
is selected andiface_electronic_scale
is false : the scale screen does not open and you can input the weight and tare through the widget => this seems inconsistent to mescale
is selected andiface_electronic_scale
is true : the scale screen opens, the scale is read.I want to remove the
iface_gross_weight_method
altogether to simplify the configuration and the code. @legalsylvain what do you think about it ?