Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] pos_product_template: Migration to 16.0 #1170

Open
wants to merge 53 commits into
base: 16.0
Choose a base branch
from

Conversation

papulo79
Copy link

@papulo79 papulo79 commented Mar 25, 2024

We've migrated the module:

  • Improve some elements in the variants pop-up like disable click action over elements that are lot clickable (variantes title or disabled confirm button)
  • Added classes that inform what variants are not clickable and are disabled.
  • As PosDB is reactive in Odoo 16, making any change to it (as patching limit to search products) triggers reactives notifications, leading to an infinite loop.
  • Added new configuration check that enables/disables the module functionality.
  • If functionality is disabled doesn't loads new modules in PoS.

FL-556-2473

@papulo79 papulo79 marked this pull request as ready for review March 25, 2024 09:21
Copy link

@Pablocce Pablocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job.

@papulo79 papulo79 changed the title [MIG][16.0] pos product template: Migration 15.0 [16.0][MIG] pos product template: Migration to 16.0 Mar 25, 2024
@papulo79 papulo79 force-pushed the 16.0-mig-pos_product_template branch 4 times, most recently from 3ef7277 to fee39db Compare March 25, 2024 16:49
@viviana1503
Copy link

LGTM! Good job!

@papulo79 papulo79 force-pushed the 16.0-mig-pos_product_template branch 8 times, most recently from 620351b to 77fbe76 Compare April 8, 2024 07:09
@legalsylvain
Copy link
Contributor

legalsylvain commented Jul 2, 2024

/ocabot migration pos_product_template

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 2, 2024
37 tasks
@legalsylvain legalsylvain changed the title [16.0][MIG] pos product template: Migration to 16.0 [16.0][MIG] pos_product_template: Migration to 16.0 Jul 2, 2024
@legalsylvain
Copy link
Contributor

Hi. Could you rebase ?

wpichler and others added 27 commits July 29, 2024 11:14
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/
This can help perfs when there are templates with a lot of variants.

Also this adds a "confirm" button that can be a practical alternative to
the variant selection.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/
Currently translated at 100.0% (9 of 9 strings)

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/es/
Co-authored-by: Daniel Duque <[email protected]>
Co-authored-by: Adriana Saiz <[email protected]>
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-pos_product_template branch from 77fbe76 to 4f28024 Compare July 29, 2024 09:37
@RodrigoBM
Copy link

Hi. Could you rebase ?

Done @legalsylvain

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor remarks inline.

@@ -14,3 +14,9 @@ class PosConfig(models.Model):
help="If selected the product variant selection screen will show the variants,"
" else it will only allow to confirm once all the attributes are chosen.",
)

iface_show_product_template = fields.Boolean(
string="Shows product template in TPV",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPV is not english.
as it is in pos_config, I guess "Show Product Templates" is enough.

iface_show_product_template = fields.Boolean(
string="Shows product template in TPV",
default=True,
help="Enables product templates in TPV",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does'nt bring anything.


def _loader_params_pos_config(self):
params = super()._loader_params_pos_config()
if params.get("search_params", {}).get("fields"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test are not usefull here, as base function return search_params and fields. (otherwise, the PoS will not work at all...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.