-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] pos_product_template: Migration to 16.0 #1170
base: 16.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job.
3ef7277
to
fee39db
Compare
LGTM! Good job! |
620351b
to
77fbe76
Compare
/ocabot migration pos_product_template |
Hi. Could you rebase ? |
[FIX] overflow bug;
[MIG] : Migration to 14.0
Currently translated at 100.0% (2 of 2 strings) Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/
…ibute_value_ids exists
This can help perfs when there are templates with a lot of variants. Also this adds a "confirm" button that can be a practical alternative to the variant selection.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/
Signed-off-by: Luis Malta <[email protected]>
Currently translated at 100.0% (9 of 9 strings) Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/
Currently translated at 100.0% (9 of 9 strings) Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/es/
Co-authored-by: Daniel Duque <[email protected]> Co-authored-by: Adriana Saiz <[email protected]>
77fbe76
to
4f28024
Compare
Done @legalsylvain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor remarks inline.
@@ -14,3 +14,9 @@ class PosConfig(models.Model): | |||
help="If selected the product variant selection screen will show the variants," | |||
" else it will only allow to confirm once all the attributes are chosen.", | |||
) | |||
|
|||
iface_show_product_template = fields.Boolean( | |||
string="Shows product template in TPV", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TPV is not english.
as it is in pos_config, I guess "Show Product Templates" is enough.
iface_show_product_template = fields.Boolean( | ||
string="Shows product template in TPV", | ||
default=True, | ||
help="Enables product templates in TPV", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does'nt bring anything.
|
||
def _loader_params_pos_config(self): | ||
params = super()._loader_params_pos_config() | ||
if params.get("search_params", {}).get("fields"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test are not usefull here, as base function return search_params and fields. (otherwise, the PoS will not work at all...)
We've migrated the module:
FL-556-2473