[16.0][REF] pos_order_to_sale_order: create method optimization #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @legalsylvain, |
GabbasovDinar
force-pushed
the
16.0-pos_order_to_sale_order-refactoring
branch
from
5665631
to
2a79a4c
Compare
| return { | ||
| "partner_id": order_data["partner_id"], | ||
| "origin": _("Point of Sale %s") % (session.name), | ||
| "client_order_ref": order_data["name"], | ||
| "user_id": order_data["user_id"], | ||
| "pricelist_id": order_data["pricelist_id"], | ||
| "fiscal_position_id": order_data["fiscal_position_id"], | ||
| "order_lines": order_lines, |
There was a problem hiding this comment.
Suggested change
| "order_lines": order_lines, | |
| "order_line": order_lines, |
https://github.com/odoo/odoo/blob/16.0/addons/sale/models/sale_order.py#L208
Should fix the CI
There was a problem hiding this comment.
@legalsylvain done
GabbasovDinar
force-pushed
the
16.0-pos_order_to_sale_order-refactoring
branch
from
2a79a4c
to
0d75cb9
Compare
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2d87948. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the process of sales order creation.
Before this changes:
Executing the create command creates an empty order, which can lead to unexpected effects if the create method has been extended by another module
After this changes:
The create method will return the order with the product lines included.