[16.0][ADD] pos_financial_risk #1018

geomer198 · 2023-06-27T21:49:23Z

Extends Partner Financial Risk to manage POS orders.
If POS order exceeds partner limit POS order forbidden to be confirmed.

ivs-cetmix · 2023-06-29T17:51:06Z

pos_financial_risk/static/src/js/ProductScreen.js

+                const total = order.get_total_with_tax() + order.get_rounding_applied();
+                if (total > partner.risk_total) {
+                    return this.showPopup("ErrorPopup", {
+                        title: _t("Confirmation order is not allowed!"),


Cannot confirm order

ivs-cetmix · 2023-06-29T17:51:46Z

pos_financial_risk/static/src/js/ProductScreen.js

+                if (total > partner.risk_total) {
+                    return this.showPopup("ErrorPopup", {
+                        title: _t("Confirmation order is not allowed!"),
+                        body: _t("Order total more than Customer risk total!"),


Order total exceeds customer credit limit

GabbasovDinar · 2023-06-29T18:27:35Z

pos_financial_risk/static/src/js/ProductScreen.js

@@ -0,0 +1,31 @@
+odoo.define("pos_financial_risk.ProductScreen", function (require) {


please use the new method to define the js files, this will be more flexible for porting to a new version of odoo in the future

/** @odoo-module **/ import ProductScreen from "point_of_sale.ProductScreen"; import Registries from "point_of_sale.Registries"; import { _t } from "web.core"; export const ProductScreenRisk = (ProductScreen) =>

and etc

GabbasovDinar · 2023-06-29T18:35:18Z

pos_financial_risk/static/src/js/ProductScreen.js

+            async _onClickPay() {
+                const order = this.env.pos.get_order();
+                const partner = order.partner;
+                if (!partner) {
+                    return super._onClickPay();
+                }
+                const total = order.get_total_with_tax() + order.get_rounding_applied();
+                if (total > partner.risk_total) {
+                    return this.showPopup("ErrorPopup", {
+                        title: _t("Confirmation order is not allowed!"),
+                        body: _t("Order total more than Customer risk total!"),
+                    });
+                }
+                return super._onClickPay();
+            }


Suggested change

async _onClickPay() {

const order = this.env.pos.get_order();

const partner = order.partner;

if (!partner) {

return super._onClickPay();

}

const total = order.get_total_with_tax() + order.get_rounding_applied();

if (total > partner.risk_total) {

return this.showPopup("ErrorPopup", {

title: _t("Confirmation order is not allowed!"),

body: _t("Order total more than Customer risk total!"),

});

}

return super._onClickPay();

}

async _onClickPay() {

const order = this.env.pos.get_order();

const partner = order.partner;

if (partner && order.get_total_with_tax() + order.get_rounding_applied() > partner.risk_total) {

return await this.showPopup("ErrorPopup", {

title: _t("Cannot confirm order"),

body: _t("Order total exceeds customer credit limit"),

});

}

return await super._onClickPay();

}

chienandalu

Probably a silly question 😅 : PoS orders are paid in the moment, shouldn't that keep the customer credit always balanced?

ivs-cetmix · 2023-06-30T08:26:11Z

Probably a silly question 😅 : PoS orders are paid in the moment, shouldn't that keep the customer credit always balanced?

Well that's a good question. Actually they should. However at some moment you would like to block a customer from purchasing anything before he pays his debt. Otherwise he can keep paying through POS without taking care of his pending balance 😅

luke-stdev001 · 2023-07-03T13:10:29Z

@geomer198 ,

I think this PR is useful and should be re-opened. We have a use-case for it internally and may want to flesh out the concept a little more. How can I contact you to discuss funding this development?

ivs-cetmix · 2023-07-03T13:22:21Z

@geomer198 ,

I think this PR is useful and should be re-opened. We have a use-case for it internally and may want to flesh out the concept a little more. How can I contact you to discuss funding this development?

Hi @luke-stdev001
We will reopen the PR. Pls ping us on [email protected]

luke-stdev001 · 2023-10-10T05:01:02Z

@geomer198 ,

Functional testing has been done and it works as expected, thanks for the changes. From my end we are ok to merge pending a code review, however we'd prefer to just pull in the OCA/POS repo rather than maintain our own version until this PR is merged here.

Would a code review from our team on this PR here help with the OCA process, or are we waiting on PSC and tests to pass for approval to merge into 16.0 for the OCA?

ivs-cetmix · 2023-10-10T11:17:15Z

@geomer198 ,

Functional testing has been done and it works as expected, thanks for the changes. From my end we are ok to merge pending a code review, however we'd prefer to just pull in the OCA/POS repo rather than maintain our own version until this PR is merged here.

Would a code review from our team on this PR here help with the OCA process, or are we waiting on PSC and tests to pass for approval to merge into 16.0 for the OCA?

@luke-stdev001 you can make a code review meanwhile. We will also do our own too

GabbasovDinar

LGTM

ivs-cetmix

Functional OK

ivantodorovich · 2023-12-18T12:56:56Z

test-requirements.txt

@@ -0,0 +1 @@
+odoo-addon-account_financial_risk @ git+https://github.com/OCA/credit-control.git@refs/pull/272/head#subdirectory=setup/account_financial_risk


Could please you rebase and update this dependency? 🙏🏻 it seems it was replaced by another PR

[MIG][16.0]account_financial_risk credit-control#272

[16.0][MIG] account_financial_risk: Migration to version 16.0 credit-control#292

ivantodorovich · 2023-12-18T12:57:43Z

pos_financial_risk/static/src/xml/PaymentScreen.xml

+                    <div class="button paymentmethod">
+                        <div
+                            class="payment-name"
+                            style="background: rgba(255, 0, 0, 0.6); cursor: not-allowed;"


It's not really a good practice to add inline styles.
The convention is to add styles through css or scss files instead

ivantodorovich · 2023-12-27T11:38:06Z

thanks!

/ocabot merge nobump

OCA-git-bot · 2023-12-27T11:38:18Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1018-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot · 2023-12-27T11:46:56Z

Congratulations, your PR was merged at 810d455. Thanks a lot for contributing to OCA. ❤️

geomer198 marked this pull request as draft June 27, 2023 21:50

geomer198 force-pushed the 16.0-t2660-pos_financial_risk-add branch from 2d052dd to 12a6e03 Compare June 27, 2023 22:30

ivs-cetmix suggested changes Jun 29, 2023

View reviewed changes

GabbasovDinar suggested changes Jun 29, 2023

View reviewed changes

chienandalu reviewed Jun 30, 2023

View reviewed changes

geomer198 closed this Jul 2, 2023

geomer198 reopened this Jul 3, 2023

geomer198 force-pushed the 16.0-t2660-pos_financial_risk-add branch from 6e833ea to 8ad21c2 Compare September 24, 2023 20:20

legalsylvain added this to the 16.0 milestone Sep 26, 2023

geomer198 force-pushed the 16.0-t2660-pos_financial_risk-add branch from 0a3217c to 609cc41 Compare September 30, 2023 20:40

GabbasovDinar approved these changes Oct 13, 2023

View reviewed changes

geomer198 force-pushed the 16.0-t2660-pos_financial_risk-add branch from 609cc41 to 6414b7d Compare October 16, 2023 18:24

geomer198 marked this pull request as ready for review October 16, 2023 18:24

ivs-cetmix approved these changes Oct 16, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 16, 2023

ivantodorovich reviewed Dec 18, 2023

View reviewed changes

geomer198 force-pushed the 16.0-t2660-pos_financial_risk-add branch from 6414b7d to 1698896 Compare December 20, 2023 12:58

[ADD] pos_financial_risk: Module add.

1632a68

geomer198 force-pushed the 16.0-t2660-pos_financial_risk-add branch from d9a698d to 1632a68 Compare December 20, 2023 13:09

ivantodorovich approved these changes Dec 27, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 27, 2023

OCA-git-bot merged commit 5a94f69 into OCA:16.0 Dec 27, 2023
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 27, 2023

ivs-cetmix deleted the 16.0-t2660-pos_financial_risk-add branch December 27, 2023 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] pos_financial_risk #1018

[16.0][ADD] pos_financial_risk #1018

geomer198 commented Jun 27, 2023

ivs-cetmix Jun 29, 2023

ivs-cetmix Jun 29, 2023

GabbasovDinar Jun 29, 2023

GabbasovDinar Jun 29, 2023

chienandalu left a comment

ivs-cetmix commented Jun 30, 2023 •

edited

Loading

luke-stdev001 commented Jul 3, 2023

ivs-cetmix commented Jul 3, 2023

luke-stdev001 commented Oct 10, 2023 •

edited

Loading

ivs-cetmix commented Oct 10, 2023

GabbasovDinar left a comment

ivs-cetmix left a comment

ivantodorovich Dec 18, 2023

ivantodorovich Dec 18, 2023

ivantodorovich commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023

		@@ -0,0 +1,31 @@
		odoo.define("pos_financial_risk.ProductScreen", function (require) {

		@@ -0,0 +1 @@
		odoo-addon-account_financial_risk @ git+https://github.com/OCA/credit-control.git@refs/pull/272/head#subdirectory=setup/account_financial_risk

[16.0][ADD] pos_financial_risk #1018

[16.0][ADD] pos_financial_risk #1018

Conversation

geomer198 commented Jun 27, 2023

ivs-cetmix Jun 29, 2023

Choose a reason for hiding this comment

ivs-cetmix Jun 29, 2023

Choose a reason for hiding this comment

GabbasovDinar Jun 29, 2023

Choose a reason for hiding this comment

GabbasovDinar Jun 29, 2023

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

ivs-cetmix commented Jun 30, 2023 • edited Loading

luke-stdev001 commented Jul 3, 2023

ivs-cetmix commented Jul 3, 2023

luke-stdev001 commented Oct 10, 2023 • edited Loading

ivs-cetmix commented Oct 10, 2023

GabbasovDinar left a comment

Choose a reason for hiding this comment

ivs-cetmix left a comment

Choose a reason for hiding this comment

ivantodorovich Dec 18, 2023

Choose a reason for hiding this comment

ivantodorovich Dec 18, 2023

Choose a reason for hiding this comment

ivantodorovich commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023

ivs-cetmix commented Jun 30, 2023 •

edited

Loading

luke-stdev001 commented Oct 10, 2023 •

edited

Loading