[17.0][MIG] sale_partner_address_restrict #1925
Conversation
|
/ocabot migration sale_partner_address_restrict |
| @api.constrains("partner_id", "partner_invoice_id", "partner_shipping_id") | ||
| def _check_partner_addresses(self): | ||
| for order in self: | ||
| if order.partner_id and ( |
There was a problem hiding this comment.
IMHO, as this changes the standard behavior, a configuration parameter should be set to activate the restriction.
There was a problem hiding this comment.
But you would not install the module if you don't want to have the restriction, don't you think?
There was a problem hiding this comment.
That has always be a debate 😄
But you maybe want to decouple deployment flows and activation. Not changing standard behavior by installing a module is always a good practice.
This allows also better flexibility.
And for our tests flows, that allows to avoid separate job flows for conflicting modules.
| @@ -0,0 +1 @@ | |||
| This module restricts the addresses to be used in the sales order form, according to the partner selected. | |||
There was a problem hiding this comment.
In which manner?
This should be improved as from module name, we don't understand how the restriction is applied.
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-16.0/partner-contact-16.0-sale_partner_address_restrict Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-sale_partner_address_restrict/it/
JordiMForgeFlow
force-pushed
the
17.0-mig-sale_partner_address_restrict
branch
from
4b72080 to
73342b9
Compare
No description provided.